[GitHub] [beam] TheNeuralBit commented on a change in pull request #15465: [BEAM-12795] When using schemas, allow state/timers use without KV objects.

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15465:
URL: https://github.com/apache/beam/pull/15465#discussion_r715186273



##########
File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/EnvironmentsTest.java
##########
@@ -249,7 +238,7 @@ public void process(ProcessContext ctxt) {}
     Environment env1 = Environments.getEnvironment(ptransform, rehydratedComponents).get();
     assertThat(
         env1,
-        equalTo(components.toComponents().getEnvironmentsOrThrow(ptransform.getEnvironmentId())));
+        equalTo(components.toComponents().getEnvironmentsOrThrow(ptransform.getEnvironmentId())));*/

Review comment:
       Is this intentional?

##########
File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/ParDoEvaluator.java
##########
@@ -100,7 +101,8 @@
               windowingStrategy,
               doFnSchemaInformation,
               sideInputMapping);
-      if (DoFnSignatures.signatureForDoFn(fn).usesState()) {
+      DoFnSignature signature = DoFnSignatures.signatureForDoFn(fn);
+      if (signature.usesState() || signature.onWindowExpiration() != null) {

Review comment:
       Is this relevant to this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org