You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/07/21 05:35:23 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20268: [feat] Enable hostname verification by default

michaeljmarshall commented on code in PR #20268:
URL: https://github.com/apache/pulsar/pull/20268#discussion_r1270242325


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -780,12 +780,9 @@ class LocalRunner extends FunctionDetailsCommand {
         @Parameter(names = "--tls-allow-insecure", description = "Allow insecure tls connection #Java, Python")
         protected boolean tlsAllowInsecureConnection;
         // for backwards compatibility purposes
-        @Parameter(names = "--hostname_verification_enabled",

Review Comment:
   The backwards compatibility has to break because we are moving `--hostname-verification-enabled` to `arity` 1. As such, users will need to update scripts in order anyway, so it seems like a reasonable time to drop the deprecated parameter.
   
   Note: we have to switch to arity 1 because otherwise JCommander will invert the meaning of the boolean flag and changing the default value will be the opposite of what users expect. See https://jcommander.org/#_boolean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org