You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/08/03 04:06:54 UTC
[GitHub] [servicecomb-kie] alec-z opened a new pull request #149: add kubernets script and doc
alec-z opened a new pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149
@tianxiaoliang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465501811
##########
File path: deployments/kubernetes/kie-deployment.yaml
##########
@@ -12,6 +12,20 @@ spec:
labels:
component: servicecomb-kie
spec:
+ volumes:
+ - name: mongo-data-pvs
+ persistentVolumeClaim:
+ claimName: mongo-data-pvc
+ - name: mongo-init-pvs
+ persistentVolumeClaim:
+ claimName: mongo-init-pvc
+ initContainers:
+ - name: down-init-db-js
+ image: busybox
+ volumeMounts:
+ - name: mongo-init-pvs
Review comment:
PersistentVolumeClaim 应该缩写为pvc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] alec-z commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
alec-z commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465574793
##########
File path: deployments/kubernetes/kie-deployment.yaml
##########
@@ -12,6 +12,20 @@ spec:
labels:
component: servicecomb-kie
spec:
+ volumes:
+ - name: mongo-data-pvs
+ persistentVolumeClaim:
+ claimName: mongo-data-pvc
+ - name: mongo-init-pvs
+ persistentVolumeClaim:
+ claimName: mongo-init-pvc
+ initContainers:
+ - name: down-init-db-js
+ image: busybox
+ volumeMounts:
+ - name: mongo-init-pvs
Review comment:
这个不是PersistentVolumeClaim，而是PersistentVolumeStorage, 简写pvs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465502126
##########
File path: docs/getstarted/install.md
##########
@@ -40,3 +40,19 @@ it will launch 3 components
- mongodb UI:http://127.0.0.1:8081
- servicecomb-kie: http://127.0.0.1:30110
+### Run with Docker kubernetes
Review comment:
Run on kubernetes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465502355
##########
File path: deployments/docker/docker-compose.yaml
##########
@@ -35,6 +35,7 @@ services:
environment:
ME_CONFIG_MONGODB_ADMINUSERNAME: kie
ME_CONFIG_MONGODB_ADMINPASSWORD: 123
+ ME_CONFIG_MONGODB_SERVER: mongo
Review comment:
这个选项做了什么
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r464229028
##########
File path: deployments/kubernetes/kie-deployment.yaml
##########
@@ -0,0 +1,74 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: kie-deployment
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ component: servicecomb-kie
+ template:
+ metadata:
+ labels:
+ component: servicecomb-kie
+ spec:
+ containers:
+ - name: servicecomb-kie
+ image: servicecomb/kie:latest
+ ports:
+ - containerPort: 30110
+ env:
+ - name: MONGODB_USER
+ value: kie
+ - name: MONGODB_PWD
+ value: '123'
+ - name: MONGODB_ADDR
+ value: localhost
Review comment:
db的地址不该是配死的，而是k8s service的name，通过name进行发现
##########
File path: deployments/kubernetes/kie-deployment.yaml
##########
@@ -0,0 +1,74 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: kie-deployment
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ component: servicecomb-kie
+ template:
+ metadata:
+ labels:
+ component: servicecomb-kie
+ spec:
+ containers:
+ - name: servicecomb-kie
+ image: servicecomb/kie:latest
+ ports:
+ - containerPort: 30110
+ env:
+ - name: MONGODB_USER
+ value: kie
+ - name: MONGODB_PWD
+ value: '123'
Review comment:
交付的应该是可按需配置的方案，所以应该提供install.sh脚本允许定制用户名密码这些配置
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] alec-z commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
alec-z commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465574260
##########
File path: deployments/docker/docker-compose.yaml
##########
@@ -35,6 +35,7 @@ services:
environment:
ME_CONFIG_MONGODB_ADMINUSERNAME: kie
ME_CONFIG_MONGODB_ADMINPASSWORD: 123
+ ME_CONFIG_MONGODB_SERVER: mongo
Review comment:
这个是默认值，就是连mongo的service的host,原来的也能工作，只是不清晰。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] alec-z commented on a change in pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
alec-z commented on a change in pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149#discussion_r465574539
##########
File path: docs/getstarted/install.md
##########
@@ -40,3 +40,19 @@ it will launch 3 components
- mongodb UI:http://127.0.0.1:8081
- servicecomb-kie: http://127.0.0.1:30110
+### Run with Docker kubernetes
Review comment:
好的，我改一下@tianxiaoliang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #149: add kubernets script and doc
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #149:
URL: https://github.com/apache/servicecomb-kie/pull/149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org