[GitHub] [rocketmq-schema-registry] MatrixHB commented on a diff in pull request #32: supplement avro compatibility checker

[GitBox <gi...@apache.org>]

MatrixHB commented on code in PR #32:
URL: https://github.com/apache/rocketmq-schema-registry/pull/32#discussion_r943534083


##########
common/src/main/java/org/apache/rocketmq/schema/registry/common/QualifiedName.java:
##########
@@ -80,18 +80,17 @@ public String subjectFullName() {
 
     @Override
     public String toString() {
-        final StringBuilder sb = new StringBuilder("{");
-        sb.append("\"cluster\":\"")

Review Comment:
   The original NotExistException uses `qualifiedName.fullname()` to return error message, so the error parameter is not clear from the `fullname`, so I change it to `toString`. 
   When using `toString()` to return error message, the HTTP will fail to parse the error message maybe because of containing quotation marks, so I change it to non JSON format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org