[PATCH] MAILBOX-205

[Benoit Tellier <bt...@linagora.com>]

Hi,

I was working on MAILBOX-146
<https://issues.apache.org/jira/browse/MAILBOX-146> to add a batch size
where needed in the StoreMessageManager ( setFlags,
deleteMarkedInMailbox, recent, copy, move ) and I add a look at the code
of the StoreMailboxManager.

I found a call to a method named *copyTo* in an other method named
*moveMessages*...

I might have missed something, but I think this might create a bug when
moveBatchSize is not null....

You will find as an attachment a patch solving this problem by replacing
the call to copyTo by moveTo in moveMessages.

Sincerly yours,

Benoit Tellier

Re: [PATCH] MAILBOX-205

[Eric Charles <er...@apache.org>]

Can you attach the patch on a jira for review ? (if not yet done)


On 12/18/2014 04:20 PM, Benoit Tellier wrote:
> Hi,
>
> I was working on MAILBOX-146
> <https://issues.apache.org/jira/browse/MAILBOX-146> to add a batch
> size where needed in the StoreMessageManager ( setFlags,
> deleteMarkedInMailbox, recent, copy, move ) and I add a look at the
> code of the StoreMailboxManager.
>
> I found a call to a method named *copyTo* in an other method named
> *moveMessages*...
>
> I might have missed something, but I think this might create a bug
> when moveBatchSize is not null....
>
> You will find as an attachment a patch solving this problem by
> replacing the call to copyTo by moveTo in moveMessages.
>
> Sincerly yours,
>
> Benoit Tellier
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org