You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Todd Feak (JIRA)" <ji...@apache.org> on 2008/10/09 00:53:44 UTC
[jira] Created: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
DisMax queries are not being cached in QueryResultCache
-------------------------------------------------------
Key: SOLR-805
URL: https://issues.apache.org/jira/browse/SOLR-805
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.3
Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
Reporter: Todd Feak
Priority: Critical
I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643335#action_12643335 ]
Shalin Shekhar Mangar commented on SOLR-805:
--------------------------------------------
Apart from this one, I don't think there are any major fixes for 1.3 branch. With Java based replication being in the trunk now, we can also plan for an early 1.4 release -- replication alone is a huge user facing feature. Of course, we need some time for the new features to stabilize, therefore, 1.4 can't be done as quick as a 1.3.1 release can be.
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Chris Harris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645876#action_12645876 ]
Chris Harris commented on SOLR-805:
-----------------------------------
I was trying to figure out exactly which revision of the Lucene trunk Koji's commit here was built against, since it doesn't seem to be stated here in JIRA or in the SVN log. If anyone else else is curious, the answer is Lucene r707499 -- at least according to the MANIFEST.MF file in lib/lucene-core-2.9-dev.jar.
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi resolved SOLR-805.
---------------------------------
Resolution: Fixed
Committed revision 707641. Thanks Todd!
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll closed SOLR-805.
--------------------------------
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Todd Feak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643008#action_12643008 ]
Todd Feak commented on SOLR-805:
--------------------------------
I'm not sure if this will help with the decision or not, but I should clarify.
This problem was not specifically with DisMax queries, though that's what I initially thought. It's with any query that would contain a MultiPhraseQuery within it. According to Yonik in the linked in bug, the SynonymFilter could inject this on a standard query. So, this problem isn't limited to DisMax, but it also may not encompass *all* DisMax queries.
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642354#action_12642354 ]
Koji Sekiguchi commented on SOLR-805:
-------------------------------------
I'll commit today if there is no objections.
{code}
$ svn status
A lib/lucene-queries-2.9-dev.jar
D lib/lucene-spellchecker-2.4.0.jar
A lib/lucene-snowball-2.9-dev.jar
D lib/lucene-analyzers-2.4.0.jar
A lib/lucene-spellchecker-2.9-dev.jar
D lib/lucene-core-2.4.0.jar
A lib/lucene-analyzers-2.9-dev.jar
D lib/lucene-highlighter-2.4.0.jar
D lib/lucene-memory-2.4.0.jar
A lib/lucene-core-2.9-dev.jar
D lib/lucene-queries-2.4.0.jar
D lib/lucene-snowball-2.4.0.jar
A lib/lucene-highlighter-2.9-dev.jar
A lib/lucene-memory-2.9-dev.jar
{code}
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Todd Feak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638639#action_12638639 ]
Todd Feak commented on SOLR-805:
--------------------------------
The fix for this has been commited to Lucene under the linked issue. Should be resolved when the referenced Lucene library is upgraded.
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Todd Feak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Feak updated SOLR-805:
---------------------------
Comment: was deleted
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642968#action_12642968 ]
Otis Gospodnetic commented on SOLR-805:
---------------------------------------
Does this call for 1.3.1 release in the very near future? Most Solr 1.3 DisMax users will probably not be able to figure this one out, yet it will hurt them.
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-805) DisMax queries are not being cached in
QueryResultCache
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated SOLR-805:
--------------------------------
Fix Version/s: 1.4
> DisMax queries are not being cached in QueryResultCache
> -------------------------------------------------------
>
> Key: SOLR-805
> URL: https://issues.apache.org/jira/browse/SOLR-805
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Environment: Using Sun JDK 1.5 and Solr 1.3.0 release on Windows XP
> Reporter: Todd Feak
> Priority: Critical
> Fix For: 1.4
>
>
> I have a DisMax Search Handler set up in my solrconfig.xml to weight results based on which field a hit was found in. Results seem to be coming back fine, but the exact same query issued twice will *not* result in a cache hit.
> I have run far enough in the debugger to determine that the hashCode for the BooleanQuery object is returning a different value each time for the same query. This leads me to believe there is some random factor involved in it's calculation, such as a default Object hashCode() implementation somewhere in the chain. Non DisMax queries seem to be caching just fine.
> Where I see this behavior exhibited is on line 47 of the QueryResultKey constructor. I have not dug in far enough to determine exactly where the hashCode is being incorrectly calculated. I will try and dig in further tomorrow, but wanted to get some attention on the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.