You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/06 20:57:30 UTC

[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14899: Add mkldnn_version.h to pip package

yuxihu commented on a change in pull request #14899: Add mkldnn_version.h to pip package
URL: https://github.com/apache/incubator-mxnet/pull/14899#discussion_r281357126
 
 

 ##########
 File path: tools/pip/setup.py
 ##########
 @@ -152,6 +152,8 @@ def has_ext_modules(self):
         package_data['mxnet'].append('mxnet/libmkldnn.so.0')
     shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/include'),
 
 Review comment:
   `mkldnn_version.h` is generated and placed under `build/include` folder. Other header files are still in this folder. So we have to copy from two different places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services