[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

["Andrew Sherman (Code Review)" <ge...@cloudera.org>]

Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 )

Change subject: IMPALA-8371: Return appropriate error code for unified backend tests
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

LGTM

http://gerrit.cloudera.org:8080/#/c/12885/2/bin/gen-backend-test-script.py
File bin/gen-backend-test-script.py:

http://gerrit.cloudera.org:8080/#/c/12885/2/bin/gen-backend-test-script.py@21
PS2, Line 21: # 1: The file location to write the generated script
Aren't these parameters now named (--gtest_filter,--test_script_output) rather than positional?


http://gerrit.cloudera.org:8080/#/c/12885/2/bin/gen-backend-test-script.py@32
PS2, Line 32: # The script template requires substitutions to set the variables used by the body.
Nit: Clearer maybe to say "the script header template".



-- 
To view, visit http://gerrit.cloudera.org:8080/12885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia146d026d42f76d5ea12d92798f299182de03eef
Gerrit-Change-Number: 12885
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 16:38:59 +0000
Gerrit-HasComments: Yes