You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/25 04:50:42 UTC
[GitHub] [shardingsphere] totalo commented on a change in pull request #13180: Support table level `queryWithCipherColumn` configuration
totalo commented on a change in pull request #13180:
URL: https://github.com/apache/shardingsphere/pull/13180#discussion_r735254594
##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/api/config/rule/EncryptTableRuleConfiguration.java
##########
@@ -32,4 +32,6 @@
private final String name;
private final Collection<EncryptColumnRuleConfiguration> columns;
+
+ private final Boolean queryWithCipherColumn;
Review comment:
In this scenario, I think null may be more appropriate. If it has a default value, the configuration may be troublesome in some special scenarios. For example, the default value is `true`, but we want to configure all tables not to be queried through encrypted columns. . I think the global configuration can have a default value, but this field of the single table can be empty, what do you think?
##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/api/config/rule/EncryptTableRuleConfiguration.java
##########
@@ -32,4 +32,6 @@
private final String name;
private final Collection<EncryptColumnRuleConfiguration> columns;
+
+ private final Boolean queryWithCipherColumn;
Review comment:
In this scenario, I think `null` may be more appropriate. If it has a default value, the configuration may be troublesome in some special scenarios. For example, the default value is `true`, but we want to configure all tables not to be queried through encrypted columns. . I think the global configuration can have a default value, but this field of the single table can be empty, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org