Re: Review Request 66879: ATLAS-2632: Tag Propagation : Tag is added to propagatedClassification twice when relationship is updated to BOTH.

[Madhan Neethiraj <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66879/#review203163
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 30, 2018, 11:33 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66879/
> -----------------------------------------------------------
> 
> (Updated April 30, 2018, 11:33 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2632
>     https://issues.apache.org/jira/browse/ATLAS-2632
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1.Create a lineage like the following :
> 
> employee ------ 1 ------> process ------- 2 -----> employee_ctas
> 
> 2.Add tag1 to employee table with propagate set to True.
> 3.Edit edge2 and set propagateTags to BOTH.
> 4.Now , in the relationship definition of edge2 , there are 2 tags "tag1" in "propagatedClassifications".
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java d04daa5d 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 91c97776 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 3b9a287f 
>   repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java 51e40f0a 
> 
> 
> Diff: https://reviews.apache.org/r/66879/diff/1/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/320/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>