[GitHub] [skywalking] zhyyu commented on issue #7169: dynamic configuration slowDBAccessThreshold rewrite confusing when not configured

[GitBox <gi...@apache.org>]

zhyyu commented on issue #7169:
URL: https://github.com/apache/skywalking/issues/7169#issuecomment-869270599


   > I want to ask where is the delete event comes from? Why it happens? Did you really delete the key?
   
   I  didn't delete the key, I just not config it. And I checked the code, found that
   
   ```
   ConfigWatcherRegister
   
   void configSync() {
           // ...
                       if (newItemValue == null) {
                           if (watcher.value() != null) {
                               // Notify watcher, the new value is null with delete event type.
                               watcher.notify(
                                   new ConfigChangeWatcher.ConfigChangeEvent(null, ConfigChangeWatcher.EventType.DELETE));
                           } else {
                               // Don't need to notify, stay in null.
                           }
         // ...
   ```
   
   So if we don't config the dynamic config, it will send delete event.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org