You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/07/31 14:38:15 UTC
(superset) branch vestigial-EMAIL_NOTIFICATIONS updated: chore: deleting vestigial EMAIL_NOTIFICATIONS
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch vestigial-EMAIL_NOTIFICATIONS
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/vestigial-EMAIL_NOTIFICATIONS by this push:
new ef7c73a552 chore: deleting vestigial EMAIL_NOTIFICATIONS
ef7c73a552 is described below
commit ef7c73a552b0e63d9437f4123eedc8271f3bb33c
Author: Evan Rusackas <ev...@rusackas.com>
AuthorDate: Tue Jul 30 19:48:44 2024 -0600
chore: deleting vestigial EMAIL_NOTIFICATIONS
---
superset/config.py | 1 -
tests/integration_tests/superset_test_config.py | 1 -
tests/integration_tests/superset_test_config_thumbnails.py | 1 -
3 files changed, 3 deletions(-)
diff --git a/superset/config.py b/superset/config.py
index 4435c22548..b39e660a4d 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -1169,7 +1169,6 @@ CONFIG_PATH_ENV_VAR = "SUPERSET_CONFIG_PATH"
FLASK_APP_MUTATOR = None
# smtp server configuration
-EMAIL_NOTIFICATIONS = False # all the emails are sent using dryrun
SMTP_HOST = "localhost"
SMTP_STARTTLS = True
SMTP_SSL = False
diff --git a/tests/integration_tests/superset_test_config.py b/tests/integration_tests/superset_test_config.py
index 0935714c54..d9444ff574 100644
--- a/tests/integration_tests/superset_test_config.py
+++ b/tests/integration_tests/superset_test_config.py
@@ -97,7 +97,6 @@ FAB_ROLES = {"TestRole": [["Security", "menu_access"], ["List Users", "menu_acce
PUBLIC_ROLE_LIKE = "Gamma"
AUTH_ROLE_PUBLIC = "Public"
-EMAIL_NOTIFICATIONS = False
REDIS_HOST = os.environ.get("REDIS_HOST", "localhost") # noqa: F405
REDIS_PORT = os.environ.get("REDIS_PORT", "6379") # noqa: F405
REDIS_CELERY_DB = os.environ.get("REDIS_CELERY_DB", 2) # noqa: F405
diff --git a/tests/integration_tests/superset_test_config_thumbnails.py b/tests/integration_tests/superset_test_config_thumbnails.py
index 8fda61e804..0850d8d79e 100644
--- a/tests/integration_tests/superset_test_config_thumbnails.py
+++ b/tests/integration_tests/superset_test_config_thumbnails.py
@@ -58,7 +58,6 @@ TESTING = True
WTF_CSRF_ENABLED = False
PUBLIC_ROLE_LIKE = "Gamma"
AUTH_ROLE_PUBLIC = "Public"
-EMAIL_NOTIFICATIONS = False
CACHE_CONFIG = {"CACHE_TYPE": "SimpleCache"}