[GitHub] [helix] narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#discussion_r311180641
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientMonitor.java
 ##########
 @@ -81,8 +90,14 @@ public ZkClientMonitor(String monitorType, String monitorKey, String monitorInst
     if (zkEventThread != null) {
       _zkEventThreadMetric = new ZkThreadMetric(zkEventThread);
     }
+    if (mbeanReservoir == null) {
+      _mbeanReservoir =  new SlidingTimeWindowArrayReservoir(DEFAULT_RESET_INTERVAL_MS, TimeUnit.MILLISECONDS);
 
 Review comment:
   @chenboat  Do we have any data/knowledge about the relationship between the reset interval (`DEFAULT_RESET_INTERVAL_MS `) and the heap usage of Reservoir implementations?
   
   Trying to see if we need to make this reset interval more explicitly configurable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org