You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/01 13:59:26 UTC
[GitHub] [airflow] ryw opened a new pull request #10675: Removes airflow-pr tool (https://github.com/apache/airflow/issues/10674)
ryw opened a new pull request #10675:
URL: https://github.com/apache/airflow/pull/10675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #10675:
URL: https://github.com/apache/airflow/pull/10675#issuecomment-685746618
thanks @potiuk :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on a change in pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
ryw commented on a change in pull request #10675:
URL: https://github.com/apache/airflow/pull/10675#discussion_r481354695
##########
File path: dev/requirements.txt
##########
@@ -1,6 +1,4 @@
click~=7.0
-jira>=2.0.0
keyring==10.1
gitpython
jinja2~=2.10
-PyGithub
Review comment:
ok - added it back in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10675:
URL: https://github.com/apache/airflow/pull/10675#discussion_r481347823
##########
File path: dev/requirements.txt
##########
@@ -1,6 +1,4 @@
click~=7.0
-jira>=2.0.0
keyring==10.1
gitpython
jinja2~=2.10
-PyGithub
Review comment:
PyGithub is used here: https://github.com/apache/airflow/blob/master/dev/airflow-github#L28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10675:
URL: https://github.com/apache/airflow/pull/10675#discussion_r481351477
##########
File path: dev/requirements.txt
##########
@@ -1,6 +1,4 @@
click~=7.0
-jira>=2.0.0
keyring==10.1
gitpython
Review comment:
You can remove `gitpython` though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10675:
URL: https://github.com/apache/airflow/pull/10675#issuecomment-685164799
🎉 - 1117 lines of code. I love those commits. They are the best ones. 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw merged pull request #10675: Remove airflow-pr tool
Posted by GitBox <gi...@apache.org>.
ryw merged pull request #10675:
URL: https://github.com/apache/airflow/pull/10675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org