[GitHub] [pulsar] ericsyh opened a new pull request #12093: feat(conf): add journalWriteData config to bk conf

[GitBox <gi...@apache.org>]

ericsyh opened a new pull request #12093:
URL: https://github.com/apache/pulsar/pull/12093


   Signed-off-by: Eric Shen <er...@outlook.com>
   
   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   Bookeeper released a feature that allows bk to bypass journal for writes in 4.14.0, you can refer the [Apache BookKeeper 4.14.0 Release Notes](https://github.com/apache/bookkeeper/blob/64102086e3bf25e52c1e019cc7f6aa13bdad2ec5/site/docs/4.14.0/overview/releaseNotes.md). The latest pulsar pkg(2.8.0) uses the bookkeeper 4.14.1 while the template bk conf misses this config, you can refer the bk config sample [bk_server.conf](https://github.com/apache/bookkeeper/blob/master/conf/bk_server.conf#L338).
   
   ### Modifications
   
   Add the config `journalWriteData` to bookkeeper.conf. 
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] doc-required 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] no-need-doc 
     
     (Please explain why)
     
   - [ ] doc 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12093: feat(conf): add journalWriteData config to bk conf

[GitBox <gi...@apache.org>]

merlimat merged pull request #12093:
URL: https://github.com/apache/pulsar/pull/12093


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org