You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 15:26:45 UTC

[GitHub] [arrow] AlenkaF commented on a diff in pull request #15049: GH-14968: [Python] Fix segfault for dataset ORC write

AlenkaF commented on code in PR #15049:
URL: https://github.com/apache/arrow/pull/15049#discussion_r1053437962


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -3074,6 +3074,28 @@ def test_orc_format_not_supported():
             ds.dataset(".", format="orc")
 
 
+def test_orc_writer_not_implemented_for_dataset():
+    try:
+        from pyarrow.dataset import OrcFileFormat  # noqa
+    except ImportError:
+        pytest.skip('this case is covered by test_orc_format_not_supported')

Review Comment:
   You could also skip the test with a pytest mark, like here: https://github.com/apache/arrow/blob/f67009aac21e8e615743bbc2933fdbf8376953f0/python/pyarrow/tests/test_dataset.py#L3004



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org