You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tiles.apache.org by ap...@apache.org on 2009/01/31 09:50:59 UTC

svn commit: r739526 - in /tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib: AddAttributeTag.java PutAttributeTag.java

Author: apetrelli
Date: Sat Jan 31 08:50:58 2009
New Revision: 739526

URL: http://svn.apache.org/viewvc?rev=739526&view=rev
Log:
TILES-361
Now the messages for the exceptions are plain strings.

Modified:
    tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/AddAttributeTag.java
    tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/PutAttributeTag.java

Modified: tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/AddAttributeTag.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/AddAttributeTag.java?rev=739526&r1=739525&r2=739526&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/AddAttributeTag.java (original)
+++ tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/AddAttributeTag.java Sat Jan 31 08:50:58 2009
@@ -200,9 +200,8 @@
             TagSupport.findAncestorWithClass(this, AddAttributeTagParent.class);
 
         if (parent == null) {
-            throw new TilesJspException("Error: enclosing tag '"
-                    + getParent().getClass().getName()
-                    + " doesn't accept 'put' tag.");
+            throw new TilesJspException(
+                    "Error: no enclosing tag accepts 'addAttribute' tag.");
         }
 
         parent.processNestedTag(this);

Modified: tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/PutAttributeTag.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/PutAttributeTag.java?rev=739526&r1=739525&r2=739526&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/PutAttributeTag.java (original)
+++ tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/PutAttributeTag.java Sat Jan 31 08:50:58 2009
@@ -21,9 +21,6 @@
 
 package org.apache.tiles.jsp.taglib;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
 import javax.servlet.jsp.tagext.TagSupport;
 
 /**
@@ -69,11 +66,6 @@
 public class PutAttributeTag extends AddAttributeTag {
 
     /**
-     * The logging object.
-     */
-    private final Log log = LogFactory.getLog(PutAttributeTag.class);
-
-    /**
      * Name of attribute to put in attribute context.
      */
     protected String name = null;
@@ -139,11 +131,8 @@
 
 
         if (parent == null) {
-            String message = "Error: enclosing tag '"
-                    + getParent().getClass().getName()
-                    + " doesn't accept 'put' tag.";
-            log.error(message);
-            throw new TilesJspException(message);
+            throw new TilesJspException(
+                    "Error: no enclosing tag accepts 'putAttribute' tag.");
         }
 
         parent.processNestedTag(this);