You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/06 18:14:17 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #5489: Implement `Debug` for `ExecutionProps`

alamb opened a new pull request, #5489:
URL: https://github.com/apache/arrow-datafusion/pull/5489

   # Which issue does this PR close?
   
   Closes https://github.com/apache/arrow-datafusion/issues/5488
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   See https://github.com/apache/arrow-datafusion/issues/5488
   
   # What changes are included in this PR?
   
   1. `#[derive(Debug)]` for `ExecutionProps`
   2. Add `Debug` to the `VarProvider` trait -- this is technically 
   
   # Are these changes tested?
   Yes, unit test
   
   # Are there any user-facing changes?
   
   Anyone who has implemented `VarProvider` will also have to now ensure they implement the `Debug` for that struct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #5489: Implement `Debug` for `ExecutionProps` and `VarProvider`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5489:
URL: https://github.com/apache/arrow-datafusion/pull/5489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5489: Implement `Debug` for `ExecutionProps`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5489:
URL: https://github.com/apache/arrow-datafusion/pull/5489#discussion_r1126846923


##########
datafusion/core/src/test/variable.rs:
##########
@@ -23,7 +23,7 @@ use crate::variable::VarProvider;
 use arrow::datatypes::DataType;
 
 /// System variable
-#[derive(Default)]
+#[derive(Default, Debug)]

Review Comment:
   This shows an example of user code that must be changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org