You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/17 12:47:29 UTC
[GitHub] [superset] simcha90 opened a new pull request #13665: fix(cross-filter): fix scheme py
simcha90 opened a new pull request #13665:
URL: https://github.com/apache/superset/pull/13665
### SUMMARY
Fix scheme.py file `chart_configuration` field
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.25%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.20% -5.26%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29768 -5993
- Misses 10848 12037 +1189
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `80.25% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.60% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.99% <100.00%> (-0.12%)` | :arrow_down: |
| sqlite | `80.22% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [505 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (363f8d4) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.50%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 70.96% -5.51%
==========================================
Files 921 838 -83
Lines 46769 41777 -4992
Branches 5644 4334 -1310
==========================================
- Hits 35761 29645 -6116
- Misses 10848 12132 +1284
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.57% <ø> (+5.25%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.59% <100.00%> (-0.53%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (363f8d4) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.20%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.26% -5.21%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29791 -5970
- Misses 10848 12014 +1166
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.57% <ø> (+5.25%)` | :arrow_up: |
| hive | `80.25% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `80.28% <100.00%> (ø)` | |
| python | `81.08% <100.00%> (-0.03%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [507 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (363f8d4) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.31%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.14% -5.32%
==========================================
Files 921 838 -83
Lines 46769 41777 -4992
Branches 5644 4334 -1310
==========================================
- Hits 35761 29724 -6037
- Misses 10848 12053 +1205
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.57% <ø> (+5.25%)` | :arrow_up: |
| hive | `80.23% <100.00%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.90% <100.00%> (-0.21%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.18%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.27% -5.19%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29797 -5964
- Misses 10848 12008 +1160
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `80.25% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.60% <100.00%> (ø)` | |
| presto | `80.28% <100.00%> (ø)` | |
| python | `81.11% <100.00%> (ø)` | |
| sqlite | `80.22% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [503 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #13665:
URL: https://github.com/apache/superset/pull/13665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (363f8d4) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.22%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.23% -5.23%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29780 -5981
- Misses 10848 12025 +1177
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.57% <ø> (+5.25%)` | :arrow_up: |
| hive | `80.25% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `80.28% <100.00%> (ø)` | |
| python | `81.04% <100.00%> (-0.08%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.52%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 70.93% -5.53%
==========================================
Files 921 838 -83
Lines 46769 41777 -4992
Branches 5644 4334 -1310
==========================================
- Hits 35761 29636 -6125
- Misses 10848 12141 +1293
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.55% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.25%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.20% -5.26%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29768 -5993
- Misses 10848 12037 +1189
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `80.23% <100.00%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.60% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.99% <100.00%> (-0.12%)` | :arrow_down: |
| sqlite | `80.22% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [505 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (363f8d4) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.16% -5.30%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29751 -6010
- Misses 10848 12054 +1206
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.57% <ø> (+5.25%)` | :arrow_up: |
| hive | `80.25% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.92% <100.00%> (-0.19%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [512 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.43%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 71.02% -5.44%
==========================================
Files 921 838 -83
Lines 46769 41805 -4964
Branches 5644 4334 -1310
==========================================
- Hits 35761 29693 -6068
- Misses 10848 12112 +1264
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.60% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.69% <100.00%> (-0.42%)` | :arrow_down: |
| sqlite | `80.22% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (35f8c48) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **increase** coverage by `4.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
+ Coverage 76.46% 80.65% +4.18%
==========================================
Files 921 310 -611
Lines 46769 25053 -21716
Branches 5644 0 -5644
==========================================
- Hits 35761 20206 -15555
+ Misses 10848 4847 -6001
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.60% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.65% <100.00%> (-0.46%)` | :arrow_down: |
| sqlite | `80.22% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.71% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.38% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [611 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13665: fix(cross-filter): fix scheme py
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13665:
URL: https://github.com/apache/superset/pull/13665#issuecomment-801075728
# [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=h1) Report
> Merging [#13665](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=desc) (efba3e0) into [master](https://codecov.io/gh/apache/superset/commit/0e0c99b2fb4cb275b65cc1293bafafe4f91ba33a?el=desc) (0e0c99b) will **decrease** coverage by `5.47%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efba3e0 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13665 +/- ##
==========================================
- Coverage 76.46% 70.98% -5.48%
==========================================
Files 921 838 -83
Lines 46769 41777 -4992
Branches 5644 4334 -1310
==========================================
- Hits 35761 29657 -6104
- Misses 10848 12120 +1272
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <ø> (+5.24%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <100.00%> (ø)` | |
| postgres | `80.59% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.64% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/13665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=footer). Last update [0e0c99b...35f8c48](https://codecov.io/gh/apache/superset/pull/13665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org