You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sateesh Chodapuneedi <sa...@citrix.com> on 2013/02/05 06:43:50 UTC

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/
-----------------------------------------------------------

(Updated Feb. 5, 2013, 5:43 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Updated description.


Description (updated)
-------

This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.


This addresses bug CLOUDSTACK-657.


Diffs
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
  vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 

Diff: https://reviews.apache.org/r/9201/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

> On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote:
> > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1001
> > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1001>
> >
> >     Do we have to be bound to a static dvSwitch0 or can this be retrieved dynamically?

This class runs functional test only, and takes dvswitch name as parameter now.


> On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote:
> > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1002
> > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1002>
> >
> >     static entry, please confirm..

This is added as command line parameter now.


> On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote:
> > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1006
> > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1006>
> >
> >     ports set to 64 - maybe to little unless its for the test, please confirm

Yes this is just for test.
We have global configuration parameter vmware.ports.per.dvportgroup to configure the number of dvports per dvportgroup created by CloudStack.
By default the number of dvports is configured as 256.
Thanks.


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16443
-----------------------------------------------------------


On Feb. 13, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 4:04 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by ilya musayev <il...@cloudsand.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16443
-----------------------------------------------------------



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34933>

    static entry, please confirm



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34930>

    Do we have to be bound to a static dvSwitch0 or can this be retrieved dynamically?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34931>

    static entry, please confirm..



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34932>

    ports set to 64 - maybe to little unless its for the test, please confirm


- ilya musayev


On Feb. 5, 2013, 5:43 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:43 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

> On Feb. 11, 2013, 9:08 p.m., ilya musayev wrote:
> > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 936
> > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line936>
> >
> >     why hardcoded IP?

Reading IP from connection url.


> On Feb. 11, 2013, 9:08 p.m., ilya musayev wrote:
> > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 964
> > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line964>
> >
> >     dvs-921 is set static?

Added parameter to specify dynamically.


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16442
-----------------------------------------------------------


On Feb. 5, 2013, 5:43 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:43 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by ilya musayev <il...@cloudsand.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16442
-----------------------------------------------------------



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34926>

    why hardcoded IP?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34927>

    hardcoded ip?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34928>

    dvs-921 is set static?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34929>

    please revise section below.


- ilya musayev


On Feb. 5, 2013, 5:43 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:43 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review17146
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Feb. 25, 2013, 11:33 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 11:33 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains test cases.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 11:33 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Moved HypervisorHostHelpers file to patch #5.


Description (updated)
-------

This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains test cases.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 

Diff: https://reviews.apache.org/r/9201/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16923
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On Feb. 19, 2013, 6:41 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 6:41 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/
-----------------------------------------------------------

(Updated Feb. 19, 2013, 6:41 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Description
-------

This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
  vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 

Diff: https://reviews.apache.org/r/9201/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

RE: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Koushik Das <ko...@citrix.com>.
You should upload the entire patch instead of the delta. Reviewboard already has the option of viewing diff between 2 revisions

From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi
Sent: Monday, February 18, 2013 10:17 AM
To: Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das
Subject: Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/



On February 17th, 2013, 2:01 p.m., Koushik Das wrote:

I can only see the test cases. Where is the changes related to prepareNetwork as you have mentioned in the description?

Revision 1 contains those changes

Link - https://reviews.apache.org/r/9201/diff/1/#index_header)

Revision 2 contains only changes to TestVmware.java files to update test cases to take test data as parameters.

PrepareNetwork changes are in HypervisorHostHelper.java in revision 1. No changes has been done in this file for revision #2.

Thanks.


- Sateesh


On February 13th, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote:
Review request for cloudstack, Murali Reddy and Kelven Yang.
By Sateesh Chodapuneedi.

Updated Feb. 13, 2013, 4:04 a.m.

Description

This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.

This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.


Testing

Manual testing:-

1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.

2) Tested both guest traffic and public traffic over dvSwitch on a physical network.

3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.

4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.





Added following tests,

1) Test fetching dvSwitch object from vCenter

2) Test for presence of dvPortGroup

3) Test presence of dvPortGroup

4) Test get existing dvPortGroup

5) fetch dvPortGroup configuration

6) Test compare dvPortGroup configuration

7) Test update dvPortGroup configuration



Bugs: CLOUDSTACK-657
Diffs

 *   vmware-base/test/com/cloud/vmware/TestVMWare.java (43c784c)

View Diff<https://reviews.apache.org/r/9201/diff/>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

> On Feb. 17, 2013, 2:01 p.m., Koushik Das wrote:
> > I can only see the test cases. Where is the changes related to prepareNetwork as you have mentioned in the description?

Revision 1 contains those changes
Link - https://reviews.apache.org/r/9201/diff/1/#index_header)
Revision 2 contains only changes to TestVmware.java files to update test cases to take test data as parameters.
PrepareNetwork changes are in HypervisorHostHelper.java in revision 1. No changes has been done in this file for revision #2.
Thanks.


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16695
-----------------------------------------------------------


On Feb. 13, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 4:04 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16695
-----------------------------------------------------------


I can only see the test cases. Where is the changes related to prepareNetwork as you have mentioned in the description?

- Koushik Das


On Feb. 13, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 4:04 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/
-----------------------------------------------------------

(Updated Feb. 13, 2013, 4:04 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Parameterized the tests. 


Description
-------

This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 

Diff: https://reviews.apache.org/r/9201/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi