[GitHub] [james-project] quantranhong1999 commented on a change in pull request #728: JAMES-3539 Implement PushSubscription/get

[GitBox <gi...@apache.org>]

quantranhong1999 commented on a change in pull request #728:
URL: https://github.com/apache/james-project/pull/728#discussion_r742624046



##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/PushSubscriptionSetMethodContract.scala
##########
@@ -194,6 +199,357 @@ trait PushSubscriptionSetMethodContract {
            |}""".stripMargin)
   }
 
+  @Test
+  def getShouldReturnEmptyWhenNone(): Unit = {

Review comment:
       Should we separate this to another SetContract? Otherwise, we should merge this contract name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org