You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alexey Varlamov <al...@gmail.com> on 2006/09/22 11:55:52 UTC
[launcher] Patch is available for "harmonyvm.properties" parsing
Dear comitters,
Please find the patch attached to HARMONY-1376 which fixes number of
issues with "harmonyvm.properties":
1) Robust file parsing with any EOLs;
2) The buffer overflow;
3) Added support for %VM_DIR% tokens, now easy to add any others;
4) Command-line "-Xbootclasspath:" option now really overrides whole BCP.
--
WBR,
Alexey
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Artem Aliev <ar...@gmail.com>.
Alexey,
Could you please put the patch again.
I got following error when try to access it.
HTTP Status 404 - Could not find specified attachment:
/usr/local/tomcat/tomcat-jira/attachments/HARMONY/HARMONY-1376/12341371_H-1376.diff
(No such file or directory)
Thanks
Artem
On 9/22/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
> Ahh, thanks! :)
>
>
> On Sep 22, 2006, at 5:55 AM, Alexey Varlamov wrote:
>
> > Dear comitters,
> >
> > Please find the patch attached to HARMONY-1376 which fixes number of
> > issues with "harmonyvm.properties":
> > 1) Robust file parsing with any EOLs;
> > 2) The buffer overflow;
> > 3) Added support for %VM_DIR% tokens, now easy to add any others;
> > 4) Command-line "-Xbootclasspath:" option now really overrides
> > whole BCP.
> >
> > --
> > WBR,
> > Alexey
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Ahh, thanks! :)
On Sep 22, 2006, at 5:55 AM, Alexey Varlamov wrote:
> Dear comitters,
>
> Please find the patch attached to HARMONY-1376 which fixes number of
> issues with "harmonyvm.properties":
> 1) Robust file parsing with any EOLs;
> 2) The buffer overflow;
> 3) Added support for %VM_DIR% tokens, now easy to add any others;
> 4) Command-line "-Xbootclasspath:" option now really overrides
> whole BCP.
>
> --
> WBR,
> Alexey
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
not yet - I grabbed the JIRA but didn't get to it yet...
On Sep 22, 2006, at 10:33 AM, Tim Ellison wrote:
> That patch file doesn't download properly for me.
>
> Anyone else have that problem?
>
> Regards,
> Tim
>
> Alexey Varlamov wrote:
>> Dear comitters,
>>
>> Please find the patch attached to HARMONY-1376 which fixes number of
>> issues with "harmonyvm.properties":
>> 1) Robust file parsing with any EOLs;
>> 2) The buffer overflow;
>> 3) Added support for %VM_DIR% tokens, now easy to add any others;
>> 4) Command-line "-Xbootclasspath:" option now really overrides
>> whole BCP.
>>
>> --
>> WBR,
>> Alexey
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>>
>>
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Tim Ellison <t....@gmail.com>.
That patch file doesn't download properly for me.
Anyone else have that problem?
Regards,
Tim
Alexey Varlamov wrote:
> Dear comitters,
>
> Please find the patch attached to HARMONY-1376 which fixes number of
> issues with "harmonyvm.properties":
> 1) Robust file parsing with any EOLs;
> 2) The buffer overflow;
> 3) Added support for %VM_DIR% tokens, now easy to add any others;
> 4) Command-line "-Xbootclasspath:" option now really overrides whole BCP.
>
> --
> WBR,
> Alexey
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Please...
On Sep 23, 2006, at 7:58 AM, Alexey Varlamov wrote:
> Ha! This is apr_file_gets() who does this!
>
> So this is DRLVM specific and duplicates classlib's efforts. We should
> get rid of this.
>
> 2006/9/23, Ivan Volosyuk <iv...@gmail.com>:
>> You are right. It is different property file:
>> $JRE/lib/boot/bootclasspath.properties (6kbyte)
>>
>> The strace looks like following. Not quite effective.
>> The number of syscalls is greater then all others at the startup of
>> VM. I would like to file a performance JIRA for the issue, but I
>> don't
>> quite understand if it DRLVM specific or classlib?
>> --
>> Ivan
>>
>> read(3, "#", 1) = 1
>> read(3, " ", 1) = 1
>> read(3, "C", 1) = 1
>> read(3, "o", 1) = 1
>> read(3, "p", 1) = 1
>> read(3, "y", 1) = 1
>> read(3, "r", 1) = 1
>> read(3, "i", 1) = 1
>> read(3, "g", 1) = 1
>> read(3, "h", 1) = 1
>> read(3, "t", 1) = 1
>> read(3, " ", 1) = 1
>> read(3, "2", 1) = 1
>> read(3, "0", 1) = 1
>> read(3, "0", 1) = 1
>> read(3, "5", 1) = 1
>> read(3, " ", 1) = 1
>> read(3, "T", 1) = 1
>> read(3, "h", 1) = 1
>> read(3, "e", 1) = 1
>> read(3, " ", 1) = 1
>> read(3, "A", 1) = 1
>>
>> --
>> Regards,
>> Ivan
>>
>> On 9/23/06, Alexey Varlamov <al...@gmail.com> wrote:
>> > I reattached the patch.
>> >
>> > Not sure this was the case Ivan talked about - launcher was
>> trying to
>> > read() the whole file at once - but anyway now file contents is
>> > mmapped for parsing.
>> >
>> > --
>> > Alexey
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Alexey Varlamov <al...@gmail.com>.
Ha! This is apr_file_gets() who does this!
So this is DRLVM specific and duplicates classlib's efforts. We should
get rid of this.
2006/9/23, Ivan Volosyuk <iv...@gmail.com>:
> You are right. It is different property file:
> $JRE/lib/boot/bootclasspath.properties (6kbyte)
>
> The strace looks like following. Not quite effective.
> The number of syscalls is greater then all others at the startup of
> VM. I would like to file a performance JIRA for the issue, but I don't
> quite understand if it DRLVM specific or classlib?
> --
> Ivan
>
> read(3, "#", 1) = 1
> read(3, " ", 1) = 1
> read(3, "C", 1) = 1
> read(3, "o", 1) = 1
> read(3, "p", 1) = 1
> read(3, "y", 1) = 1
> read(3, "r", 1) = 1
> read(3, "i", 1) = 1
> read(3, "g", 1) = 1
> read(3, "h", 1) = 1
> read(3, "t", 1) = 1
> read(3, " ", 1) = 1
> read(3, "2", 1) = 1
> read(3, "0", 1) = 1
> read(3, "0", 1) = 1
> read(3, "5", 1) = 1
> read(3, " ", 1) = 1
> read(3, "T", 1) = 1
> read(3, "h", 1) = 1
> read(3, "e", 1) = 1
> read(3, " ", 1) = 1
> read(3, "A", 1) = 1
>
> --
> Regards,
> Ivan
>
> On 9/23/06, Alexey Varlamov <al...@gmail.com> wrote:
> > I reattached the patch.
> >
> > Not sure this was the case Ivan talked about - launcher was trying to
> > read() the whole file at once - but anyway now file contents is
> > mmapped for parsing.
> >
> > --
> > Alexey
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Ivan Volosyuk <iv...@gmail.com>.
You are right. It is different property file:
$JRE/lib/boot/bootclasspath.properties (6kbyte)
The strace looks like following. Not quite effective.
The number of syscalls is greater then all others at the startup of
VM. I would like to file a performance JIRA for the issue, but I don't
quite understand if it DRLVM specific or classlib?
--
Ivan
read(3, "#", 1) = 1
read(3, " ", 1) = 1
read(3, "C", 1) = 1
read(3, "o", 1) = 1
read(3, "p", 1) = 1
read(3, "y", 1) = 1
read(3, "r", 1) = 1
read(3, "i", 1) = 1
read(3, "g", 1) = 1
read(3, "h", 1) = 1
read(3, "t", 1) = 1
read(3, " ", 1) = 1
read(3, "2", 1) = 1
read(3, "0", 1) = 1
read(3, "0", 1) = 1
read(3, "5", 1) = 1
read(3, " ", 1) = 1
read(3, "T", 1) = 1
read(3, "h", 1) = 1
read(3, "e", 1) = 1
read(3, " ", 1) = 1
read(3, "A", 1) = 1
--
Regards,
Ivan
On 9/23/06, Alexey Varlamov <al...@gmail.com> wrote:
> I reattached the patch.
>
> Not sure this was the case Ivan talked about - launcher was trying to
> read() the whole file at once - but anyway now file contents is
> mmapped for parsing.
>
> --
> Alexey
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Alexey Varlamov <al...@gmail.com>.
2006/9/23, Geir Magnusson Jr. <ge...@pobox.com>:
> On Sep 23, 2006, at 6:59 AM, Alexey Varlamov wrote:
>
> > I reattached the patch.
> >
>
> Thanks, I saw that.
>
>
> > Not sure this was the case Ivan talked about - launcher was trying to
> > read() the whole file at once - but anyway now file contents is
> > mmapped for parsing.
>
> Do you have any portability concerns with that solution?
Not at the moment, at least. Anyway this is isolated in the shared
parser and can be fixed trivially.
>
> >
> > --
> > Alexey
> >
> > 2006/9/23, Geir Magnusson Jr. <ge...@pobox.com>:
> >> Hopefully we'll know when we get the actual patch.
> >>
> >> geir
> >>
> >> On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote:
> >>
> >> > When 'stracing' loading of VM I saw quite inefficient way to load a
> >> > file from disk. Reading one byte at a time by read() call. If
> >> I'm not
> >> > mistaken it was this property file. Is this issue fixed in the
> >> JIRA?
> >> > (Just curious)
> >> > --
> >> > Ivan
> >> >
> >> > On 9/22/06, Alexey Varlamov <al...@gmail.com> wrote:
> >> >> Dear comitters,
> >> >>
> >> >> Please find the patch attached to HARMONY-1376 which fixes
> >> number of
> >> >> issues with "harmonyvm.properties":
> >> >> 1) Robust file parsing with any EOLs;
> >> >> 2) The buffer overflow;
> >> >> 3) Added support for %VM_DIR% tokens, now easy to add any others;
> >> >> 4) Command-line "-Xbootclasspath:" option now really overrides
> >> >> whole BCP.
> >> >
> >> >
> >> ---------------------------------------------------------------------
> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > To unsubscribe, e-mail: harmony-dev-
> >> unsubscribe@incubator.apache.org
> >> > For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
On Sep 23, 2006, at 6:59 AM, Alexey Varlamov wrote:
> I reattached the patch.
>
Thanks, I saw that.
> Not sure this was the case Ivan talked about - launcher was trying to
> read() the whole file at once - but anyway now file contents is
> mmapped for parsing.
Do you have any portability concerns with that solution?
>
> --
> Alexey
>
> 2006/9/23, Geir Magnusson Jr. <ge...@pobox.com>:
>> Hopefully we'll know when we get the actual patch.
>>
>> geir
>>
>> On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote:
>>
>> > When 'stracing' loading of VM I saw quite inefficient way to load a
>> > file from disk. Reading one byte at a time by read() call. If
>> I'm not
>> > mistaken it was this property file. Is this issue fixed in the
>> JIRA?
>> > (Just curious)
>> > --
>> > Ivan
>> >
>> > On 9/22/06, Alexey Varlamov <al...@gmail.com> wrote:
>> >> Dear comitters,
>> >>
>> >> Please find the patch attached to HARMONY-1376 which fixes
>> number of
>> >> issues with "harmonyvm.properties":
>> >> 1) Robust file parsing with any EOLs;
>> >> 2) The buffer overflow;
>> >> 3) Added support for %VM_DIR% tokens, now easy to add any others;
>> >> 4) Command-line "-Xbootclasspath:" option now really overrides
>> >> whole BCP.
>> >
>> >
>> ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-
>> unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Alexey Varlamov <al...@gmail.com>.
I reattached the patch.
Not sure this was the case Ivan talked about - launcher was trying to
read() the whole file at once - but anyway now file contents is
mmapped for parsing.
--
Alexey
2006/9/23, Geir Magnusson Jr. <ge...@pobox.com>:
> Hopefully we'll know when we get the actual patch.
>
> geir
>
> On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote:
>
> > When 'stracing' loading of VM I saw quite inefficient way to load a
> > file from disk. Reading one byte at a time by read() call. If I'm not
> > mistaken it was this property file. Is this issue fixed in the JIRA?
> > (Just curious)
> > --
> > Ivan
> >
> > On 9/22/06, Alexey Varlamov <al...@gmail.com> wrote:
> >> Dear comitters,
> >>
> >> Please find the patch attached to HARMONY-1376 which fixes number of
> >> issues with "harmonyvm.properties":
> >> 1) Robust file parsing with any EOLs;
> >> 2) The buffer overflow;
> >> 3) Added support for %VM_DIR% tokens, now easy to add any others;
> >> 4) Command-line "-Xbootclasspath:" option now really overrides
> >> whole BCP.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Hopefully we'll know when we get the actual patch.
geir
On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote:
> When 'stracing' loading of VM I saw quite inefficient way to load a
> file from disk. Reading one byte at a time by read() call. If I'm not
> mistaken it was this property file. Is this issue fixed in the JIRA?
> (Just curious)
> --
> Ivan
>
> On 9/22/06, Alexey Varlamov <al...@gmail.com> wrote:
>> Dear comitters,
>>
>> Please find the patch attached to HARMONY-1376 which fixes number of
>> issues with "harmonyvm.properties":
>> 1) Robust file parsing with any EOLs;
>> 2) The buffer overflow;
>> 3) Added support for %VM_DIR% tokens, now easy to add any others;
>> 4) Command-line "-Xbootclasspath:" option now really overrides
>> whole BCP.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [launcher] Patch is available for "harmonyvm.properties" parsing
Posted by Ivan Volosyuk <iv...@gmail.com>.
When 'stracing' loading of VM I saw quite inefficient way to load a
file from disk. Reading one byte at a time by read() call. If I'm not
mistaken it was this property file. Is this issue fixed in the JIRA?
(Just curious)
--
Ivan
On 9/22/06, Alexey Varlamov <al...@gmail.com> wrote:
> Dear comitters,
>
> Please find the patch attached to HARMONY-1376 which fixes number of
> issues with "harmonyvm.properties":
> 1) Robust file parsing with any EOLs;
> 2) The buffer overflow;
> 3) Added support for %VM_DIR% tokens, now easy to add any others;
> 4) Command-line "-Xbootclasspath:" option now really overrides whole BCP.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org