[GitHub] [incubator-devlake-helm-chart] IronCore864 commented on a diff in pull request #121: Feat: include security context

["IronCore864 (via GitHub)" <gi...@apache.org>]

IronCore864 commented on code in PR #121:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/121#discussion_r1184476479


##########
charts/devlake/values.yaml:
##########
@@ -182,6 +207,25 @@ ui:
     useSecret: false
     autoCreateSecret: true
     secretName: devlake-auth
+  
+  extraLabels: {}
+
+  ## SecurityContext holds pod-level security attributes and common container settings.
+  ## This defaults to non root user with uid 101 and gid 1000. *v1.PodSecurityContext  false

Review Comment:
   Shall we add more context here? For example, stating that the Nginx base image uses uid:gid 101:101, so the uid/fsgroup must be 101 and can't be changed, otherwise config-ui won't be able to overwrite the default config file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org