[jira] Commented: (ZOOKEEPER-192) trailing whitespace in config file can cause number format exceptions

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711917#action_12711917 ] 

Hadoop QA commented on ZOOKEEPER-192:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408748/ZOOKEEPER-192.patch
  against trunk revision 777265.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/console

This message is automatically generated.

> trailing whitespace in config file can cause number format exceptions
> ---------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-192
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-192
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-192.patch
>
>
> a config file with trailing whitespace can cause number format exception
> for example a line such as
> clientPort=2181
> where 2181 is followed by a space character, will fail to parse with number format excetion "2181 " (notice the space).
> We need to trim whitespace when parsing numbers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.