You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/09 00:58:35 UTC
[GitHub] [superset] betodealmeida opened a new pull request #17695: feat: bypass cache on screenshots for alerts (WIP)
betodealmeida opened a new pull request #17695:
URL: https://github.com/apache/superset/pull/17695
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-994265139
> @betodealmeida does this use a different cache key for reports or by running an alert/report that busts the cache, does it update the explore view as well?
It's the same cache, so it should update the explore view as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-994227573
@betodealmeida does this use a different cache key for reports or by running an alert/report that busts the cache, does it update the explore view as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995330748
@betodealmeida If alert triggers a dashboard, will every chart in the dashboard have force refresh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995339656
> @betodealmeida If alert triggers a dashboard, will every chart in the dashboard have force refresh?
That's a great question... right now I'm adding this just for charts, not dashboards. Maybe for dashboards we should also make it configurable (default off), since the impact can be much bigger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #17695:
URL: https://github.com/apache/superset/pull/17695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #17695:
URL: https://github.com/apache/superset/pull/17695#discussion_r769220289
##########
File path: superset-frontend/src/explore/exploreUtils/getExploreLongUrl.test.ts
##########
@@ -45,12 +45,27 @@ test('Get url when endpointType:standalone', () => {
expect(
getExploreLongUrl(
params.formData,
- params.endpointType,
Review comment:
This test was wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995314981
@betodealmeida Thanks for the PR. I have 1 question, this change only impact `Alert` but not `Report`, right?
Thinking about if a user setup email **_report_** for a large dashboard, and with 1 min as frequency, it might impact backend query engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995315438
> @betodealmeida Thanks for the PR. I have 1 question, this change only impact `Alert` but not `Report`, right? Thinking about if a user setup email **_report_** for a large dashboard, and with 1 min as frequency, it might impact backend query engine.
Right, this is just for alerts. For reports I have another PR that makes it configurable, with the default being to use the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995314981
@betodealmeida Thanks for the PR. I have 1 question: this change only affect `Alert` but not `Report`, right?
Thinking about if a user setup email **_report_** for a large dashboard, and with 1 min as frequency, it might impact backend query engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #17695: feat: bypass cache on screenshots for alerts
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #17695:
URL: https://github.com/apache/superset/pull/17695#issuecomment-995348354
> Maybe for dashboards we should also make it configurable (default off), since the impact can be much bigger?
agree. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org