You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/22 01:45:49 UTC
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1129: BugFix: Aggregate with having statement
ulysses-you commented on a change in pull request #1129:
URL: https://github.com/apache/incubator-kyuubi/pull/1129#discussion_r713530156
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/watchdog/ForcedMaxOutputRowsRule.scala
##########
@@ -49,8 +50,12 @@ case class ForcedMaxOutputRowsRule(session: SparkSession) extends Rule[LogicalPl
maxOutputRowsOpt match {
case Some(forcedMaxOutputRows) => val supported = p match {
+ case agg: Aggregate => agg match {
+ case Aggregate(_, Alias(_, "havingCondition")::Nil, _) => false
Review comment:
can we code ?
```
case Filter(_, _: Aggregate) =>
case _: Aggregate =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org