You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/23 14:03:50 UTC

[GitHub] [pulsar] lhotari opened a new pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

lhotari opened a new pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048


   Fixes #11045
   
   ### Motivation
   
   Fixes flaky test ResourceGroupConfigListenerTest
   
   ### Modifications
   
   - remove `atMost` and rely on Awaitility default of 10 seconds.
   - refactor deletion test to not use Thread.sleep
     - first check that all resource groups exist
     - then delete


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048#issuecomment-866940999


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048#issuecomment-867019873


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048#issuecomment-867020012


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11048:
URL: https://github.com/apache/pulsar/pull/11048#issuecomment-866938095


   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org