[GitHub] [beam] riteshghorse commented on a diff in pull request #22897: Add map state in the Go Sdk

[GitBox <gi...@apache.org>]

riteshghorse commented on code in PR #22897:
URL: https://github.com/apache/beam/pull/22897#discussion_r956240694


##########
sdks/go/pkg/beam/core/runtime/exec/userstate.go:
##########
@@ -106,12 +110,12 @@ func (s *stateProvider) WriteValueState(val state.Transaction) error {
 	return nil
 }
 
-// ReadBagState reads a ReadBagState state from the State API
+// ReadBagState reads a BagState state from the State API

Review Comment:
   ```suggestion
   // ReadBagState reads a bag state from the State API
   ```



##########
sdks/go/pkg/beam/core/runtime/exec/userstate.go:
##########
@@ -162,6 +165,105 @@ func (s *stateProvider) WriteBagState(val state.Transaction) error {
 	return nil
 }
 
+// ReadMapStateValue reads a value from the map state given a key.

Review Comment:
   ```suggestion
   // ReadMapStateValue reads a value from the map state for a given map key.
   ```



##########
sdks/go/pkg/beam/core/state/state_test.go:
##########
@@ -116,6 +117,50 @@ func (s *fakeProvider) ExtractOutputFn(userStateID string) reflectx.Func {
 	return nil
 }
 
+// ReadMapStateValue(userStateID string, key interface{}) (interface{}, []Transaction, error)

Review Comment:
   Did you mean to add doc comments for the functions below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org