You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kwmonroe <gi...@git.apache.org> on 2017/05/10 16:37:10 UTC

[GitHub] bigtop pull request #205: BIGTOP-2764: deployment failure when roles include...

GitHub user kwmonroe opened a pull request:

    https://github.com/apache/bigtop/pull/205

    BIGTOP-2764: deployment failure when roles include spark::common and spark::yarn*

    We need to ensure the `spark-datanucleus` package is only defined once.  There's a hack in place so it is always defined in `spark::common` (see BIGTOP-2268):
    
    https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/spark/manifests/init.pp#L154
    
    This PR comments out the other definition, which should be reinstated if/when 2268 is fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/juju-solutions/bigtop bug/BIGTOP-2764/duplicate-datanucleus

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #205
    
----
commit 28e001443a3aaf2db390496e35763eaa7b94926f
Author: Kevin W Monroe <ke...@canonical.com>
Date:   2017-05-10T16:32:24Z

    BIGTOP-2764: remove duplicate spark-datanucleus definition

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #205: BIGTOP-2764: deployment failure when roles include spark:...

Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:

    https://github.com/apache/bigtop/pull/205
  
    Closed by https://github.com/apache/bigtop/commit/73864a30b29ee89655772ce82b4041c2564d0711


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #205: BIGTOP-2764: deployment failure when roles include spark:...

Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on the issue:

    https://github.com/apache/bigtop/pull/205
  
    Thanks for the review @ktsakalozos.
    +1 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #205: BIGTOP-2764: deployment failure when roles include spark:...

Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:

    https://github.com/apache/bigtop/pull/205
  
    I've updated the original workaround to include `spark::datanucleus` instead of redefining the package.  This is much cleaner than including multiple comment blocks to explain the 2268 hack.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #205: BIGTOP-2764: deployment failure when roles include spark:...

Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:

    https://github.com/apache/bigtop/pull/205
  
    [spark-39](https://jujucharms.com/spark/39) contains this fix, and is green across clouds for hadoop + spark in yarn mode:
    
    http://bigtop.charm.qa/cwr_bundle_hadoop_spark/33/report.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request #205: BIGTOP-2764: deployment failure when roles include...

Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe closed the pull request at:

    https://github.com/apache/bigtop/pull/205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #205: BIGTOP-2764: deployment failure when roles include spark:...

Posted by ktsakalozos <gi...@git.apache.org>.
Github user ktsakalozos commented on the issue:

    https://github.com/apache/bigtop/pull/205
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---