You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/26 01:47:49 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2402: Config.mk: fix CATFILE macro to work when file list is empty (Linux)

v01d opened a new pull request #2402:
URL: https://github.com/apache/incubator-nuttx/pull/2402


   ## Summary
   
   The change makes CATFILE work as expected for an empty list. Fixes #2401 
   
   ## Impact
   
   Affected build (make depend) on Linux when CSRCS/ASRCS was empty.
   
   ## Testing
   
   esp32-core:wapi on Linux
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2402: Config.mk: fix CATFILE macro to work when file list is empty (Linux)

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2402:
URL: https://github.com/apache/incubator-nuttx/pull/2402#issuecomment-734334317


   Thanks, I believe I fixed it. Also, I hardcoded Make.dep there unintentionally.
   I don't really like that this kind of error does not produce an error to make itself. Not sure if there's a better way to handle this so that it does.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2402: Config.mk: fix CATFILE macro to work when file list is empty (Linux)

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2402:
URL: https://github.com/apache/incubator-nuttx/pull/2402


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2402: Config.mk: fix CATFILE macro to work when file list is empty (Linux)

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2402:
URL: https://github.com/apache/incubator-nuttx/pull/2402#issuecomment-734397159


   > I, too, dislike the fact that some errors go mostly unnoticed to make. I had a similar issue before.
   > I think for this case we have to explicitly check the return of the commands called.
   
   Yes, I tried that, but it seems this kind of syntax error does not generate an different exit status.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org