[GitHub] pnowojski opened a new pull request #6981: [FLINK-10638][table] Invalid table scan resolution for temporal join queries

[GitBox <gi...@apache.org>]

pnowojski opened a new pull request #6981: [FLINK-10638][table] Invalid table scan resolution for temporal join queries
URL: https://github.com/apache/flink/pull/6981
 
 
   Previously there was a strict fixed order of applying LogicalCorrelateToTemporalTableJoinRule
   and TableScanRule rules. This was causing problems, since either of them could create a new
   RelNodes that have to be subject of the other rule (imagine deeply nested TemporalTableFunction
   that references registered tables/views and other TemporalTableFunctions).
   
   Solution to this problem is to run both of those rules in one group/collection in HepPlaner.
   Instead of applying one rule to whole tree then the other rule, both rules are applied to
   a parent node, before going down/deeper.
   
   ## Verifying this change
   
   This change modify existing tests to provide test coverage against this bug.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no ****/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services