You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/01 17:43:47 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5117: coerce `utf8` to `interval` and `timestamp` (including arguments to `date_bin`)

alamb commented on code in PR #5117:
URL: https://github.com/apache/arrow-datafusion/pull/5117#discussion_r1093545155


##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -76,6 +76,18 @@ SELECT DATE_BIN(INTERVAL '15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTA
 ----
 2022-08-03T14:30:00
 
+# Can coerce string interval arguments
+query T
+SELECT DATE_BIN('15 minutes', TIMESTAMP '2022-08-03 14:38:50Z', TIMESTAMP '1970-01-01T00:00:00Z') AS res

Review Comment:
   I think you are right -- `res` is not needed. I will remove them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org