You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Zhao Yongming (JIRA)" <ji...@apache.org> on 2012/06/06 04:36:22 UTC
[jira] [Created] (TS-1289) stats codes mess up when disk fail
Zhao Yongming created TS-1289:
---------------------------------
Summary: stats codes mess up when disk fail
Key: TS-1289
URL: https://issues.apache.org/jira/browse/TS-1289
Project: Traffic Server
Issue Type: Bug
Components: Cache, Stats
Affects Versions: 3.3.0
Reporter: Zhao Yongming
Assignee: Zhao Yongming
Fix For: 3.3.0
patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1289) stats codes mess up when disk fail
Posted by "Zhao Yongming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289910#comment-13289910 ]
Zhao Yongming commented on TS-1289:
-----------------------------------
{code}
commit bf70a5e0613b278c386608ce6f1902eb5b014d05
Author: Zhao Yongming <mi...@gmail.com>
Date: Wed Jun 6 10:36:17 2012 +0800
TS-1289 stats codes mess up when disk fail
diff --git a/iocore/cache/Cache.cc b/iocore/cache/Cache.cc
index 864918a..7ebb99d 100644
--- a/iocore/cache/Cache.cc
+++ b/iocore/cache/Cache.cc
@@ -1685,13 +1685,13 @@ AIO_Callback_handler::handle_disk_failure(int event, void *data) {
if (d->fd == gvol[p]->fd) {
total_dir_delete += gvol[p]->buckets * gvol[p]->segments * DIR_DEPTH;
used_dir_delete += dir_entries_used(gvol[p]);
- total_bytes_delete = gvol[p]->len - vol_dirlen(gvol[p]);
+ total_bytes_delete += gvol[p]->len - vol_dirlen(gvol[p]);
}
}
RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_bytes_delete);
- RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_dir_delete);
- RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -cache_direntries_used_stat);
+ RecIncrGlobalRawStat(cache_rsb, cache_direntries_total_stat, -total_dir_delete);
+ RecIncrGlobalRawStat(cache_rsb, cache_direntries_used_stat, -used_dir_delete);
if (theCache) {
rebuild_host_table(theCache);
{code}
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.0
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1289) stats codes mess up when disk fail
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-1289:
---------------------------
Backport to Version: 3.2.1
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.0
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1289) stats codes mess up when disk fail
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-1289:
---------------------------
Backport to Version: (was: 3.2.3)
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.0
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1289) stats codes mess up when disk fail
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić resolved TS-1289.
----------------------------
Resolution: Fixed
Fix Version/s: (was: 3.3.1)
3.3.0
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.0
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1289) stats codes mess up when disk fail
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418737#comment-13418737 ]
Igor Galić commented on TS-1289:
--------------------------------
The SHA1 is wrong, this is the correct one: 99cbf8acb97b191631882bfcfaf06d512347fdd4
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.0
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1289) stats codes mess up when disk fail
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-1289:
---------------------------
Backport to Version: 3.2.3 (was: 3.2.1)
> stats codes mess up when disk fail
> ----------------------------------
>
> Key: TS-1289
> URL: https://issues.apache.org/jira/browse/TS-1289
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Stats
> Affects Versions: 3.3.0
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Fix For: 3.3.1
>
>
> patch talks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira