You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "zyratlo (via GitHub)" <gi...@apache.org> on 2026/10/12 21:40:20 UTC
[PR] feat(notebook-migration): add r files to the import modal [texera]
zyratlo opened a new pull request, #8963:
URL: https://github.com/apache/texera/pull/8963
### What changes were proposed in this PR?
> [!NOTE]
> Stacked on #8912, which is stacked on #8911 and #8910. Until those merge, this diff also shows their commits.
This PR lets users convert R files, using the R script conversion from #8911. It is the second UI PR for R support (#8009), after R notebooks in #8912. R folders follow in their own PR.
**Import modal.** An "R File" tab after Python Folder, laid out like the Python File tab: its own diagram, a description, and an upload row that accepts `.R` and `.r`. It is one more entry in the `IMPORT_TABS` list from #8912, which is all the language and tab logic it needs.
**Disabled, not hidden.** As with the R Notebook option in #8912, the tab is always shown. When `rNotebookMigrationEnabled` is off it is greyed out, cannot be selected, and its title shows the tooltip "R is not enabled on this deployment."
**Dispatch.** A small per language table now holds each language's script extension and messages. For R, the dashboard accepts `.ipynb` or `.R` / `.r`, and anything else gets "Please upload an R Jupyter Notebook (.ipynb) or an R (.R) file." R files go through the R script conversion, and a file that cannot be read gets R wording. Python's messages are unchanged.
**Assets.** A new R file diagram, at the same size and border as the others. `frontend/LICENSE-binary` adds it to the Material Symbols entry.
#### Demo video (waiting time cut out)
https://github.com/user-attachments/assets/fc1dc88a-452b-41ca-a972-22e4e9617e53
#### R File disabled on a deployment without R
<img width="308" height="88" alt="image" src="https://github.com/user-attachments/assets/261f86ac-77a0-4a7f-99ff-6a15da1310f5" />
### Any related issues, documentation, discussions?
Part of #8009
Parent-issue #4301
The plan is in https://github.com/apache/texera/discussions/8866. Language mismatches between the upload and the selected tab are tracked in #8929.
### How was this PR tested?
* `notebook-import-modal.component.spec.ts`, four new tests: the tab is disabled with its tooltip while the R flag is off and a click does not select it; while the flag is on it shows its diagram, accepts `.R,.r` and reports the R language; and submit passes `"r"`. The tab count assertion now expects four tabs, and the tooltip lookup finds each tooltip by the element it is attached to, since the modal now has two.
* `user-workflow.component.spec.ts`, three new tests: `.R` and `.r` convert as R scripts, and an unreadable R file gets R wording. The R test from #8912 now rejects a `.py`, since `.R` is accepted here, and the Python script assertion now expects `"python"`.
The full frontend suite passes.
Checked by hand against a local stack. With the R flag off, the R File tab is disabled, ignores clicks and shows its tooltip. With it on, the tab shows its diagram, description and `.R,.r` upload row, a staged file clears on changing tabs, and no tab scrolls. An R file converted end to end with a live model.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(notebook-migration): add r files to the import modal [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8963:
URL: https://github.com/apache/texera/pull/8963#issuecomment-6133191289
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 8 worse · ⚪ 7 noise (<±5%) · 0 without baseline
> Compared against main `9cf43f2` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/38312089642)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 516 | 0.315 | 18,755/27,541/27,541 us | 🔴 +13.6% / 🔴 +75.2% |
| 🔴 | bs=100 sw=10 sl=64 | 1,182 | 0.721 | 84,433/104,740/104,740 us | 🔴 +19.3% / 🟢 +15.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,408 | 0.859 | 707,854/757,899/757,899 us | ⚪ within ±5% / 🟢 +32.9% |
<details><summary>Baseline details</summary>
Latest main `9cf43f2` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 516 tuples/sec | 575 tuples/sec | 790.31 tuples/sec | -10.3% | -34.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.315 MB/s | 0.351 MB/s | 0.482 MB/s | -10.3% | -34.7% |
| bs=10 sw=10 sl=64 | p50 | 18,755 us | 16,503 us | 12,375 us | +13.6% | +51.6% |
| bs=10 sw=10 sl=64 | p95 | 27,541 us | 27,722 us | 15,719 us | -0.7% | +75.2% |
| bs=10 sw=10 sl=64 | p99 | 27,541 us | 27,722 us | 19,058 us | -0.7% | +44.5% |
| bs=100 sw=10 sl=64 | throughput | 1,182 tuples/sec | 1,267 tuples/sec | 1,025 tuples/sec | -6.7% | +15.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.721 MB/s | 0.773 MB/s | 0.626 MB/s | -6.7% | +15.3% |
| bs=100 sw=10 sl=64 | p50 | 84,433 us | 78,796 us | 98,759 us | +7.2% | -14.5% |
| bs=100 sw=10 sl=64 | p95 | 104,740 us | 87,813 us | 105,327 us | +19.3% | -0.6% |
| bs=100 sw=10 sl=64 | p99 | 104,740 us | 87,813 us | 120,491 us | +19.3% | -13.1% |
| bs=1000 sw=10 sl=64 | throughput | 1,408 tuples/sec | 1,432 tuples/sec | 1,059 tuples/sec | -1.7% | +32.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.859 MB/s | 0.874 MB/s | 0.646 MB/s | -1.7% | +32.9% |
| bs=1000 sw=10 sl=64 | p50 | 707,854 us | 702,831 us | 965,886 us | +0.7% | -26.7% |
| bs=1000 sw=10 sl=64 | p95 | 757,899 us | 737,836 us | 1,007,533 us | +2.7% | -24.8% |
| bs=1000 sw=10 sl=64 | p99 | 757,899 us | 737,836 us | 1,031,622 us | +2.7% | -26.5% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,387.76,200,128000,516,0.315,18754.56,27540.92,27540.92
1,100,10,64,20,1692.50,2000,1280000,1182,0.721,84433.03,104740.39,104740.39
2,1000,10,64,20,14204.80,20000,12800000,1408,0.859,707854.38,757898.50,757898.50
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(notebook-migration): add r files to the import modal [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8963:
URL: https://github.com/apache/texera/pull/8963#issuecomment-6133166542
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8963?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.61%. Comparing base ([`4c982a7`](https://app.codecov.io/gh/apache/texera/commit/4c982a7a8abba119b326b19456f4ef7fda78f059?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd150fc`](https://app.codecov.io/gh/apache/texera/commit/bd150fc47fe9ff9db29b1b100d89d1a68d4c18ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 21 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8963 +/- ##
==========================================
Coverage 92.60% 92.61%
- Complexity 5044 5057 +13
==========================================
Files 1252 1259 +7
Lines 53580 53834 +254
Branches 6672 6714 +42
==========================================
+ Hits 49616 49856 +240
Misses 2317 2317
- Partials 1647 1661 +14
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.09% <100.00%> (-0.01%)` | :arrow_down: | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.50% <100.00%> (+0.12%)` | :arrow_up: | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.00% <ø> (+0.47%)` | :arrow_up: | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.59% <100.00%> (-0.01%)` | :arrow_down: | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.52% <ø> (ø)` | | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (-1.67%)` | :arrow_down: | Carriedforward from [1122c60](https://app.codecov.io/gh/apache/texera/commit/1122c605e9c0fe339933c2a5a7e0d73337dd3ddc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8963?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(notebook-migration): add r files to the import modal [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8963:
URL: https://github.com/apache/texera/pull/8963#issuecomment-6133117901
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`, `@yangzhang75`, `@Neilk1021`
You can notify them by mentioning `@mengw15`, `@yangzhang75`, `@Neilk1021` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org