You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/11 10:30:21 UTC
[GitHub] [hive] kgyrtkirk opened a new pull request #1154: HIVE-23728 metastore verify
kgyrtkirk opened a new pull request #1154:
URL: https://github.com/apache/hive/pull/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1154: HIVE-23728 metastore verify
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1154:
URL: https://github.com/apache/hive/pull/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1154: HIVE-23728 metastore verify
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1154:
URL: https://github.com/apache/hive/pull/1154#issuecomment-696455704
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #1154: HIVE-23728: Run metastore verification tests during precommit
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #1154:
URL: https://github.com/apache/hive/pull/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1154: HIVE-23728 metastore verify
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1154:
URL: https://github.com/apache/hive/pull/1154#issuecomment-696455704
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1154: HIVE-23728: Run metastore verification tests during precommit
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1154:
URL: https://github.com/apache/hive/pull/1154#discussion_r566916606
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mssql.java
##########
@@ -72,8 +72,9 @@ public String getInitialJdbcUrl(String hostAddress) {
}
@Override
- public boolean isContainerReady(String logOutput) {
- return logOutput.contains(
+ public boolean isContainerReady(ProcessResults pr) {
+ return pr.stdout
Review comment:
~~Can `pr` or `pr.stdout` be null?~~
Checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1154: HIVE-23728: Run metastore verification tests during precommit
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1154:
URL: https://github.com/apache/hive/pull/1154#discussion_r566916606
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mssql.java
##########
@@ -72,8 +72,9 @@ public String getInitialJdbcUrl(String hostAddress) {
}
@Override
- public boolean isContainerReady(String logOutput) {
- return logOutput.contains(
+ public boolean isContainerReady(ProcessResults pr) {
+ return pr.stdout
Review comment:
Can `pr` or `pr.stdout` be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1154: HIVE-23728 metastore verify
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1154:
URL: https://github.com/apache/hive/pull/1154#issuecomment-696455704
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1154: HIVE-23728: Run metastore verification tests during precommit
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1154:
URL: https://github.com/apache/hive/pull/1154#issuecomment-769060118
@pvary @pvargacl the final patch only adds mysql beyond the existing derby and postgres databases - but it enables the precommit tests to run the integration tests for those databases during precommit runs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1154: HIVE-23728: Run metastore verification tests during precommit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1154:
URL: https://github.com/apache/hive/pull/1154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org