Re: [PR] IGNITE-24525 Synchronize table removals and Raft snapshots [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #5588:
URL: https://github.com/apache/ignite-3/pull/5588#discussion_r2039213516


##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -240,18 +238,9 @@ private PartitionSnapshotMeta takeSnapshotMeta(int catalogVersion, Collection<Pa
         }
     }
 
-    private List<PartitionMvStorageAccess> freezePartitionStorages(int catalogVersion) {
-        Catalog catalog = catalogService.catalog(catalogVersion);
-
+    private List<PartitionMvStorageAccess> freezePartitionStorages() {
         if (partitionKey instanceof ZonePartitionKey) {
-            int zoneId = ((ZonePartitionKey) partitionKey).zoneId();
-
             return partitionsByTableId.values().stream()
-                    .filter(storage -> {

Review Comment:
   Note to reviewer: I have no idea why this code was here in the first place



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org