Re: [PR] Implement SHOW FUNCTIONS [datafusion]

["findepi (via GitHub)" <gi...@apache.org>]

findepi commented on code in PR #12266:
URL: https://github.com/apache/datafusion/pull/12266#discussion_r1741872728


##########
datafusion/sql/src/statement.rs:
##########
@@ -1588,6 +1592,37 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         self.statement_to_plan(rewrite.pop_front().unwrap()) // length of rewrite is 1
     }
 
+    fn show_functions_to_plan(
+        &self,
+        filter: Option<ShowStatementFilter>,
+    ) -> Result<LogicalPlan> {
+        if filter.is_some() {

Review Comment:
   that is a good idea.
   however, i think sqlparser-rs has the syntax potentialy mixed up.
   the filter syntax is borrowed from MySQL while the statement itself isn't borrowed from there, creating a unique mix. see https://github.com/sqlparser-rs/sqlparser-rs/issues/1399
   it would be best to resolve this (either fix or close the issue) before jumping on the filtering support



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org