You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by xiang li <wa...@gmail.com> on 2014/07/30 08:24:10 UTC

Review Request 24089: Review request for FLUME-1920. Hadoop jar related code is removed, as file channel does not have dependency on hadoop any more

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24089/
-----------------------------------------------------------

Review request for Flume.


Bugs: https://issues.apache.org/jira/browse/FLUME-1920
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1920


Repository: flume-git


Description
-------

Remove hadoop jar related code from both TestFileChannel.java and StagedInstall.java, because the dependency on hadoop is removed from file channel


Diffs
-----

  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java 2feb506 
  flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java 336ffc4 

Diff: https://reviews.apache.org/r/24089/diff/


Testing
-------

This is a test case change. Tested it using JDK 1.7


Thanks,

xiang li


Re: Review Request 24089: Review request for FLUME-1920. Hadoop jar related code is removed, as file channel does not have dependency on hadoop any more

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24089/#review49778
-----------------------------------------------------------

Ship it!


Ship It!

- Mike Percy


On July 30, 2014, 6:24 a.m., xiang li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24089/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 6:24 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-1920
>     https://issues.apache.org/jira/browse/FLUME-1920
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Remove hadoop jar related code from both TestFileChannel.java and StagedInstall.java, because the dependency on hadoop is removed from file channel
> 
> 
> Diffs
> -----
> 
>   flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java 2feb506 
>   flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java 336ffc4 
> 
> Diff: https://reviews.apache.org/r/24089/diff/
> 
> 
> Testing
> -------
> 
> This is a test case change. Tested it using JDK 1.7
> 
> 
> Thanks,
> 
> xiang li
> 
>


Re: Review Request 24089: Review request for FLUME-1920. Hadoop jar related code is removed, as file channel does not have dependency on hadoop any more

Posted by xiang li <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24089/
-----------------------------------------------------------

(Updated July 30, 2014, 6:24 a.m.)


Review request for Flume.


Bugs: FLUME-1920
    https://issues.apache.org/jira/browse/FLUME-1920


Repository: flume-git


Description
-------

Remove hadoop jar related code from both TestFileChannel.java and StagedInstall.java, because the dependency on hadoop is removed from file channel


Diffs
-----

  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java 2feb506 
  flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java 336ffc4 

Diff: https://reviews.apache.org/r/24089/diff/


Testing
-------

This is a test case change. Tested it using JDK 1.7


Thanks,

xiang li