[jira] [Commented] (SENTRY-1387) Add HDFS sync tests for drop partition for external/implicit locations

["Nachiket Vaidya (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856682#comment-15856682 ] 

Nachiket Vaidya commented on SENTRY-1387:
-----------------------------------------

makeMetastoreBasePartitionObject() assigns the table location in partition. This is the root cause of this behavior.
There are two versions of makeMetastorePartitionObject() that call makeMetastoreBasePartitionObject(). One sets given location and other keeps the location unchanged (which is table location).

To fix this: set the partition location to null in makeMetastoreBasePartitionObject(). It will auto-generated by Hive in the format : <part_column>=<part_value>.

> Add HDFS sync tests for drop partition for external/implicit locations
> ----------------------------------------------------------------------
>
>                 Key: SENTRY-1387
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1387
>             Project: Sentry
>          Issue Type: Test
>            Reporter: Sravya Tirukkovalur
>
> One thing I noted is: When a partition is added to a implicit location (with out using 'location' keyword), the location is stored as table location rather than partition location. So, I think we need to double check if we have coverage for these cases and make sure we handle this correctly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)