[GitHub] [doris] yujun777 commented on a diff in pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response

["yujun777 (via GitHub)" <gi...@apache.org>]

yujun777 commented on code in PR #20996:
URL: https://github.com/apache/doris/pull/20996#discussion_r1234643837


##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -351,17 +348,12 @@ private ArrayList<AddPartitionClause> getAddPartitionClause(Database db, OlapTab
      */
     private void setStorageMediumProperty(HashMap<String, String> partitionProperties,
             DynamicPartitionProperty property, ZonedDateTime now, int hotPartitionNum, int offset) {
-        if ((hotPartitionNum <= 0 || offset + hotPartitionNum <= 0) && !property.getStorageMedium()
+        if (hotPartitionNum <= 0 || offset + hotPartitionNum <= 0 || property.getStorageMedium()
                 .equalsIgnoreCase("ssd")) {
             return;
         }
-        String cooldownTime;
-        if (property.getStorageMedium().equalsIgnoreCase("ssd")) {
-            cooldownTime = TimeUtils.longToTimeString(DataProperty.MAX_COOLDOWN_TIME_MS);

Review Comment:
   mistook assume that no cooldown time equals max cooldown time.   rollback this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org