[GitHub] [rocketmq] lizhimins commented on a diff in pull request #5655: [ISSUE #5654] calculate inflight messages for pop

[GitBox <gi...@apache.org>]

lizhimins commented on code in PR #5655:
URL: https://github.com/apache/rocketmq/pull/5655#discussion_r1041851024


##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java:
##########
@@ -209,7 +211,16 @@ private RemotingCommand processRequest(final Channel channel, RemotingCommand re
             && putMessageResult.getPutMessageStatus() != PutMessageStatus.SLAVE_NOT_AVAILABLE) {
             POP_LOGGER.error("put ack msg error:" + putMessageResult);
         }
+        decInFlightMessageNum(requestHeader);
         return response;
     }
 
+    private void decInFlightMessageNum(AckMessageRequestHeader requestHeader) {

Review Comment:
   use the full name "decrement" maybe better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org