You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by pt...@apache.org on 2015/02/25 23:09:59 UTC

[4/5] storm git commit: Change log level for intentionally dropping messages from WARN to ERROR

Change log level for intentionally dropping messages from WARN to ERROR

This change makes the log level for dropping messages consistent in
Client.java.

Signed-off-by: P. Taylor Goetz <pt...@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/9138d9fc
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/9138d9fc
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/9138d9fc

Branch: refs/heads/0.9.3-branch
Commit: 9138d9fc255639b4d0d43657379ce467591e8ef2
Parents: 97a76fc
Author: Michael G. Noll <mn...@verisign.com>
Authored: Mon Feb 16 10:07:35 2015 +0100
Committer: P. Taylor Goetz <pt...@gmail.com>
Committed: Tue Feb 24 18:09:56 2015 -0500

----------------------------------------------------------------------
 storm-core/src/jvm/backtype/storm/messaging/netty/Client.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/9138d9fc/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java b/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java
index 77c20c8..afce496 100644
--- a/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java
+++ b/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java
@@ -370,7 +370,7 @@ public class Client extends ConnectionWithStatus implements IStatefulObject {
     public synchronized void send(Iterator<TaskMessage> msgs) {
         if (closing) {
             int numMessages = iteratorSize(msgs);
-            LOG.warn("discarding {} messages because the Netty client to {} is being closed", numMessages,
+            LOG.error("discarding {} messages because the Netty client to {} is being closed", numMessages,
                 dstAddressPrefixedName);
             return;
         }
@@ -487,7 +487,7 @@ public class Client extends ConnectionWithStatus implements IStatefulObject {
                     messagesSent.getAndAdd(batch.size());
                 }
                 else {
-                    LOG.warn("failed to send {} messages to {}: {}", numMessages, dstAddressPrefixedName,
+                    LOG.error("failed to send {} messages to {}: {}", numMessages, dstAddressPrefixedName,
                         future.getCause());
                     closeChannelAndReconnect(future.getChannel());
                     messagesLost.getAndAdd(numMessages);