You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/20 07:16:59 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
zhfeng opened a new pull request, #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1402016785
Many thanks! This is awesome and helpful.
Just quick question, will it open a PR every time a new quarkiverse dependency is released ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398082960
Good time to experiment with new tools right after a release. Thus few questions.
Will dependabot upgrade versions only linked to CVEs ?
Or upgrade to any new release quarkiverse.* version available ?
Also, in case a new quarkiverse.* version is available but we would skip it in camel-quarkus, because of a bug for instance. Then, how could we skip that version ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398178560
yeah. I think we can use `ignore` in yaml file to skip some artifacts or some version we don't want to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398171473
So, when we want to skip a version. Then we just modify the yaml file ?
That would be a nice way to document what quarkiverse updates are dangling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398419074
Indeed, well spotted, not all updates are to be consumed.
Also, I'm thinking the dependabot approach would encourage to increase each quarkiverse.* version independently. I see this as a benefit at this stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398272370
> I would vote to experiment with this.
>
> I wonder what other think ?
Yeah let's see how it works for us.
For `quarkus-amazon-services` we maybe need to be a bit careful. I don't think we always want to merge version upgrades, given that project is a Quarkus Platform member and we should not use a version higher than what is specified there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398129700
It could open a PR for any new release of quarkiverse artifacts we are using. More details on https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
Of casue we can skip a version if it is not feasible for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1415366364
@zbendhiba yeah, it checks daily and will open a PR for new release of quarkiverse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org