[GitHub] [iotdb] Alima777 commented on a change in pull request #1367: [IOTDB-749] Handle select * from root OOM

[GitBox <gi...@apache.org>]

Alima777 commented on a change in pull request #1367:
URL: https://github.com/apache/iotdb/pull/1367#discussion_r508169315



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/optimizer/ConcatPathOptimizer.java
##########
@@ -180,34 +192,26 @@ private void concatSelect(List<PartialPath> fromPaths, SelectOperator selectOper
       }
     }
 
-    removeStarsInPath(allPaths, afterConcatAggregations, selectOperator);
+    removeStarsInPath(allPaths, afterConcatAggregations, selectOperator, limit, offset);
   }
 
   /**
    * Make 'SLIMIT&SOFFSET' take effect by trimming the suffixList and aggregations of the
    * selectOperator.
    *
-   * @param seriesLimit  is ensured to be positive integer
    * @param seriesOffset is ensured to be non-negative integer
    */
-  private void slimitTrim(SelectOperator select, int seriesLimit, int seriesOffset)
+  private void slimitTrim(SelectOperator select, int seriesOffset)
       throws LogicalOptimizeException {

Review comment:
       From my perspective, limit is done in concatselect() while this method is only for trimming the `offset` of aggregations. 
   If I'm right, please modify the method name and java doc of it.

##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -323,7 +327,7 @@ merge_throughput_mb_per_sec=16
 meta_data_cache_enable=true
 # Read memory Allocation Ratio: ChunkMetadataCache, ChunkCache, TimeSeriesMetadataCache and Free Memory Used in Query.
 # The parameter form is a:b:c:d, where a, b, c and d are integers. for example: 1:1:1:1 , 6:10:5:15
-chunkmeta_chunk_timeseriesmeta_free_memory_proportion=1:1:1:7
+chunkmeta_chunk_timeseriesmeta_free_memory_proportion=1:1:1:3:4

Review comment:
       I agree with that. The comments need to be modified.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org