[jira] [Commented] (HADOOP-18511) TestDecayRpcScheduler.testPriority is a flaky test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625282#comment-17625282 ] 

ASF GitHub Bot commented on HADOOP-18511:
-----------------------------------------

Kerr0220 opened a new pull request, #5085:
URL: https://github.com/apache/hadoop/pull/5085

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   This PR aims to solve the issue here: https://issues.apache.org/jira/browse/HADOOP-18511
   
   The fix is to sort the properties returned by getAttribute() so that the non-deterministic behavior can be eliminated completely. In this way, the test becomes more stable and it will not suffer from failure anymore.
   
   ### How was this patch tested?
   Execute `mvn test` locally on vm with environment:
   ```
   Apache Maven 3.6.0;
   openjdk version "1.8.0_342";
   OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
   OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
   ```
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-18511. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> TestDecayRpcScheduler.testPriority is a flaky test
> --------------------------------------------------
>
>                 Key: HADOOP-18511
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18511
>             Project: Hadoop Common
>          Issue Type: Bug
>         Environment: Apache Maven 3.6.0;
> openjdk version "1.8.0_342";
> OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
> OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
> h4.
>            Reporter: Yiteng Zhang
>            Priority: Trivial
>
>  
> {code:java}
> org.apache.hadoop.ipc.TestDecayRpcScheduler.testPriority{code}
> This is a flaky test, it can pass maven-test while showing non-deterministic behavior under [NonDex|[https://github.com/TestingResearchIllinois/NonDex]] and thus failed.
> The test shows below:
> {code:java}
> java.lang.AssertionError: Get expected JMX of CallVolumeSummary before decay
>     at org.junit.Assert.fail(Assert.java:89)
>     at org.junit.Assert.assertTrue(Assert.java:42)
>     at org.apache.hadoop.ipc.TestDecayRpcScheduler.testPriority(TestDecayRpcScheduler.java:295){code}
> *Steps to reproduce the failure:*
>  # install [NonDex|https://github.com/TestingResearchIllinois/NonDex]
>  # run the following command in hadoop: 
> {code:java}
> MODULE=hadoop-common-project/hadoop-common
> TEST=org.apache.hadoop.ipc.TestDecayRpcScheduler#testPriority   
> mvn install -pl $MODULE -am -DskipTests 
> mvn -pl $MODULE edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=$TEST{code}
>       3. the result will be saved under the package folder in .nondex
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org