[jira] [Commented] (TEZ-330) Ignore rack-local / non-local configs for tasks which do not need locality

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746929#comment-13746929 ] 

Bikas Saha commented on TEZ-330:
--------------------------------

Looks good. Main concern is that we are both honoring and not-honoring rack locality. There is a flag for it but the check is for node local. While this may seem tractable now, it may be a source of issues later on. We could remove the rack local flag and make everything consistent if we are mainly concerned with node locality.

typo
{code}
hasPendingNodeLocalRequeuest()
{code}

IMO, the test will make more sense if there is an existing local request that is not assigned. Or else its not clear that the second task was assigned because its the only remaining task. Reusing an existing test that checks for delayed assignment may be useful than creating a new test. The first reuse can be made immediately at ANY locality and the second reuse can be made delayed because it was local.
                
> Ignore rack-local / non-local configs for tasks which do not need locality
> --------------------------------------------------------------------------
>
>                 Key: TEZ-330
>                 URL: https://issues.apache.org/jira/browse/TEZ-330
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>              Labels: TEZ-0.2.0
>         Attachments: TEZ-330.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira