You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/09 14:13:02 UTC
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #566: CI also check the build with CMake status on ubuntu
tisonkun commented on code in PR #566:
URL: https://github.com/apache/incubator-kvrocks/pull/566#discussion_r868059568
##########
.github/workflows/kvrocks.yaml:
##########
@@ -34,6 +34,7 @@ jobs:
matrix:
os: [ubuntu-18.04]
runs-on: ${{ matrix.os }}
+ needs: license # wait for license job
Review Comment:
```suggestion
needs: [license]
```
Redundant comment.
##########
.github/workflows/kvrocks.yaml:
##########
@@ -78,8 +79,31 @@ jobs:
cd tests/tcl && sh runtest
sh runtest --single integration/redis-cli && cd -
+ build-on-ubuntu-with-cmake:
+ strategy:
+ matrix:
+ os: [ubuntu-18.04]
+ runs-on: ${{ matrix.os }}
+ needs: license # wait for license job
Review Comment:
```suggestion
needs: [license]
```
Redundant comment.
##########
.github/workflows/kvrocks.yaml:
##########
@@ -78,8 +79,31 @@ jobs:
cd tests/tcl && sh runtest
sh runtest --single integration/redis-cli && cd -
+ build-on-ubuntu-with-cmake:
Review Comment:
I'm considering whether we can build only with cmake so that we should maintain only one build system. It's inspired by an ongoing effort #564. But we can discuss in details there later.
##########
.github/workflows/kvrocks.yaml:
##########
@@ -78,8 +79,31 @@ jobs:
cd tests/tcl && sh runtest
sh runtest --single integration/redis-cli && cd -
+ build-on-ubuntu-with-cmake:
+ strategy:
+ matrix:
+ os: [ubuntu-18.04]
+ runs-on: ${{ matrix.os }}
+ needs: license # wait for license job
+ steps:
+ - name: Checkout Code Base
+ uses: actions/checkout@v2.3.4
+ with:
+ fetch-depth: 64
+
+ - name: Install Dependencies
+ run: |
+ sudo apt update
+ sudo apt-get install -y gcc g++ cmake
+ mkdir _build
+
+ - name: Build
+ run: |
+ sh build.sh _build
+
build-on-macos-latest:
runs-on: macos-11
+ needs: license # wait for license job
Review Comment:
```suggestion
needs: [license]
```
Redundant comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org