[GitHub] [ozone] ashishkumar50 commented on a diff in pull request #4646: HDDS-8514. Improve ozone admin cert list subcommand count limits

["ashishkumar50 (via GitHub)" <gi...@apache.org>]

ashishkumar50 commented on code in PR #4646:
URL: https://github.com/apache/ozone/pull/4646#discussion_r1183949983


##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/cert/ListSubcommand.java:
##########
@@ -46,6 +46,8 @@ public class ListSubcommand extends ScmCertSubcommand {
   private static final Logger LOG =
       LoggerFactory.getLogger(ListSubcommand.class);
 
+  private static final int MAX_FETCHED_CERTIFICATES = 999;

Review Comment:
   MAX_FETCHED_CERTIFICATES is unused, You can remove it.



##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/cert/ListSubcommand.java:
##########
@@ -91,6 +93,10 @@ protected void execute(SCMSecurityProtocol client) throws IOException {
         startSerialId, count, isRevoked);
     LOG.info("Certificate list:(Type={}, BatchSize={}, CertCount={})",
         type.toUpperCase(), count, certPemList.size());
+    if (count == certPemList.size()) {
+      LOG.info("The certificate list could be longer than the batch size. " +
+          "Please use the \"-c\" option to see more certificates.");

Review Comment:
   I think we can improve message here by printing value of batch size too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org