[GitHub] [camel-website] essobedo commented on a diff in pull request #825: Promote the usage of yarn in docker

[GitBox <gi...@apache.org>]

essobedo commented on code in PR #825:
URL: https://github.com/apache/camel-website/pull/825#discussion_r850236753


##########
yarn-in-docker.sh:
##########
@@ -5,4 +5,4 @@
 # $yarn-in-docker.sh workspace antora-ui-camel run build
 
 docker build -t camel-website .
-docker run --rm -it -v $(pwd):/work:Z --workdir /work camel-website yarn $*
+docker run --rm -it --env-file yarn-in-docker.env -v $(pwd):/work:Z --workdir /work camel-website yarn $*

Review Comment:
   It is not really a flexible approach if for some reason we need more env variables, we will then have to modify the script too moreover you still need to set the env variables locally 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org