You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/05/15 01:50:11 UTC
Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/
-----------------------------------------------------------
Review request for Ambari, Florian Barca and Jayush Luniya.
Bugs: AMBARI-11150
https://issues.apache.org/jira/browse/AMBARI-11150
Repository: ambari
Description
-------
[WinTP2] Ambari Windows services description should not include version
Diffs
-----
ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
Diff: https://reviews.apache.org/r/34243/diff/
Testing
-------
tested manually
Thanks,
Artem Baranchuk
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/#review83983
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On May 15, 2015, 12:16 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34243/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 12:16 p.m.)
>
>
> Review request for Ambari, Florian Barca and Jayush Luniya.
>
>
> Bugs: AMBARI-11150
> https://issues.apache.org/jira/browse/AMBARI-11150
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Ambari Windows services description should not include version
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 5831e11
> ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 9d74f27
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py b901e5c
> ambari-server/src/main/python/ambari_windows_service.py 502aeb9
>
> Diff: https://reviews.apache.org/r/34243/diff/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/#review83935
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On May 15, 2015, 12:16 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34243/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 12:16 p.m.)
>
>
> Review request for Ambari, Florian Barca and Jayush Luniya.
>
>
> Bugs: AMBARI-11150
> https://issues.apache.org/jira/browse/AMBARI-11150
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Ambari Windows services description should not include version
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 5831e11
> ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 9d74f27
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py b901e5c
> ambari-server/src/main/python/ambari_windows_service.py 502aeb9
>
> Diff: https://reviews.apache.org/r/34243/diff/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/
-----------------------------------------------------------
(Updated Май 15, 2015, 12:16 п.п.)
Review request for Ambari, Florian Barca and Jayush Luniya.
Bugs: AMBARI-11150
https://issues.apache.org/jira/browse/AMBARI-11150
Repository: ambari
Description
-------
[WinTP2] Ambari Windows services description should not include version
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 5831e11
ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 9d74f27
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py b901e5c
ambari-server/src/main/python/ambari_windows_service.py 502aeb9
Diff: https://reviews.apache.org/r/34243/diff/
Testing
-------
tested manually
Thanks,
Artem Baranchuk
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/#review83878
-----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/ambari_service.py
<https://reviews.apache.org/r/34243/#comment134954>
If _AdjustServiceVersion() is no longer used at all, how about you remove it altogether.
- Florian Barca
On May 15, 2015, 12:11 a.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34243/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 12:11 a.m.)
>
>
> Review request for Ambari, Florian Barca and Jayush Luniya.
>
>
> Bugs: AMBARI-11150
> https://issues.apache.org/jira/browse/AMBARI-11150
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Ambari Windows services description should not include version
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 5831e11
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 9d74f27
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py b901e5c
> ambari-server/src/main/python/ambari_windows_service.py 502aeb9
>
> Diff: https://reviews.apache.org/r/34243/diff/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/
-----------------------------------------------------------
(Updated Май 15, 2015, 12:11 д.п.)
Review request for Ambari, Florian Barca and Jayush Luniya.
Bugs: AMBARI-11150
https://issues.apache.org/jira/browse/AMBARI-11150
Repository: ambari
Description
-------
[WinTP2] Ambari Windows services description should not include version
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 5831e11
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 9d74f27
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py b901e5c
ambari-server/src/main/python/ambari_windows_service.py 502aeb9
Diff: https://reviews.apache.org/r/34243/diff/
Testing
-------
tested manually
Thanks,
Artem Baranchuk
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Florian Barca <fb...@hortonworks.com>.
> On May 14, 2015, 11:56 p.m., Florian Barca wrote:
> > Ship It!
The display name is still version-dependent, which is something the work item doesn't mention.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/#review83873
-----------------------------------------------------------
On May 14, 2015, 11:50 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34243/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 11:50 p.m.)
>
>
> Review request for Ambari, Florian Barca and Jayush Luniya.
>
>
> Bugs: AMBARI-11150
> https://issues.apache.org/jira/browse/AMBARI-11150
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Ambari Windows services description should not include version
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
>
> Diff: https://reviews.apache.org/r/34243/diff/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34243: [WinTP2] Ambari Windows services description
should not include version
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34243/#review83873
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On May 14, 2015, 11:50 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34243/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 11:50 p.m.)
>
>
> Review request for Ambari, Florian Barca and Jayush Luniya.
>
>
> Bugs: AMBARI-11150
> https://issues.apache.org/jira/browse/AMBARI-11150
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Ambari Windows services description should not include version
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3
>
> Diff: https://reviews.apache.org/r/34243/diff/
>
>
> Testing
> -------
>
> tested manually
>
>
> Thanks,
>
> Artem Baranchuk
>
>